Codex Teleport ability is offensive

[Iridar]

X2AbilityTemplate has Hostility = eHostility_Offensive by default, and Codex' Teleport doesn't set anything else to it, which can cause some unexpected ability interactions.

I believe this to be an oversight, because as a general rule, abilities shouldn't be offensive unless they apply damage or negative effects.

[Iridar]

Other teleport abilities could be having the same issues, to be checked.

[faanlez]

IcarusJump would be one of those, and TriggerSuperposition and TriggerDamagedTeleport.

Also, while not teleports, Revive and Holy Warrior are marked hostile as well.

[srinathupadhyayula]

Could this have been intentional to make them react-able by coveringfire?

[Iridar]

Most likely an oversight.

[faanlez]

TeleportAlly is another one.

[Iridar]

I logged all offensive abilities that don't deal damage, and furry fox there's a lot:

LethalDose
Knockout
Revive
RemoteStart
ParryActivate
Amplify
TemplarInvert
GhostKill
VoidConduit
PoisonSpit
EndBind
GetOverHere
WrathCannonStage1
Suppression
Teleport
TriggerSuperposition
PsiBombStage1
TeleportMP
MarkTarget
Stasis
Fuse
FusePostActivationConcealmentBreaker
Domination
PsiOperativeMindControl
HolyWarriorM1
HolyWarriorM2
HolyWarriorM3
PriestStasis
PriestPsiMindControl
HolyWarriorMP
PsiMindControl
TriggerDamagedTeleport
BlazingPinionsStage1
BlazingPinionsStage1MP
ImpairingAbility
SpawnChryssalid
SpawnChryssalidMP
ChosenKidnap
ChosenExtractKnowledge
ChosenWarningMarkUp
ChosenActivation
ChosenReveal
ChosenEngaged
ChosenDirectedAttack
ChosenSummonFollowers
ChosenDefeatedEscape
Corrupt
MindScorch
Possess
TeleportAlly
TriggerPsiSelfDestruct
SpectralArmyImpairingAbility
Mindspin
DelayedPsiExplosion
PsiReanimation
PsiReanimationMP
ChryssalidBurrow
ChryssalidUnburrow
BurrowedAttack
UnburrowSawEnemy
ApplyBurning
ChangeForm
ChangeFormSawEnemy
ThrowGrenade
LaunchGrenade
GrenadeFuse
ExplosiveDeviceDetonate
DelayedExecute
Execute
Counterattack
SkirmisherVengeance
JudgmentTrigger
SkirmisherInterrupt
StunImpairingAbility
ArchonKingBlazingPinionsStage1
IcarusDropGrab
AlienRulerActionSystem
Faithbreaker
RagePanic
IcarusPanic
SerpentPanic
FreezingLash
IcarusJump
KingEndBind
KingGetOverHere
IntimidateTrigger
HunterProtocolTrigger
TriggerSelfDestruct

[Iridar]

Since the issue is about teleports, let's handle just those:

TemplarInvert
Teleport
TriggerSuperposition
TeleportMP
TriggerDamagedTeleport
TeleportAlly
IcarusJump

TemplarInvert is the one that swaps positions with an enemy, which I think is actually fine to keep offensive, since it's a skill you specifically target an enemy with.