Show more-info icon for all revealed abilities #42
Comments
|
I implemented something like this in a LWOTC commit, but it only checks whether |
|
Makes sense. Let's handle this after #45 is dealt with so there's no merge conflict with the _Column class. |
|
I don't think this needs to wait on a PR that isn't finalised and is in a minor state of limbo right now. It will be fine to rebase #45 when we've found and agreed upon a solution for it. Plus it may not even have changes to the hero column class once it's done. |
|
Alright, I'll handle it. |
|
Addressed in 1f270fd Performed sufficient testing to make sure it works without issues. |
Iridar
added a commit
that referenced
this issue
Jun 16, 2021
5b866db Release v1.1.0 1dd9936 Merge pull request #28 from robojumper/remove_verification 1b88ae5 Update README with information about X2ProjectGenerator 60a8235 Rip project file verification out of build_common 6647121 Merge pull request #42 from robojumper/changelog f6b7c1c Changelog the 2nd 702c0f4 Merge pull request #38 from robojumper/profile f126426 Don't set the thread's culture just for a decimal dot 3f602dc Add self-profiling to report step timings ed7a5f2 Merge pull request #31 from robojumper/check-macro-redefs 81c0216 More descriptive macro redefinition error message 0da0304 Merge pull request #39 from robojumper/future-proof adf7f69 Use release tags in installation instructions instead of pulling main 8817f76 Don't delete XComGame\Published in clean.ps1 8da626f Error out on macro redefinitions as a stopgap measure da647e0 Merge pull request #29 from robojumper/changelog f825c12 Merge pull request #27 from robojumper/error-file-line-syntax 06f9d17 Add rolling changelog 0c508eb Use error syntax compatible with both ModBuddy and VS Code git-subtree-dir: .scripts/X2ModBuildCommon git-subtree-split: 5b866db251265ebcdc17d631de2539ab927e112e
Iridar
added a commit
that referenced
this issue
Nov 17, 2021
c7e3945 Release v1.1.1 cb83114 Merge pull request #60 from pledbrook/patch-3 932381d Merge pull request #59 from X2CommunityCore/fail-on-sdk-revert-fail d4e3e9b Merge pull request #56 from robojumper/55-spaces-in-project-path 63ff7e3 Make path rewriting aware of IncludeSrc (#57) ccf2109 Remove /DCOPY:DA robocopy option 93da7dc Added a check (and fail) for post-cooking SDK cleanup b78de7e Add disclaimer about spaces to README, update CHANGELOG a72ea3d Fix mod project paths containing spaces becea48 Merge pull request #53 from X2CommunityCore/revert-dlc-cook 305bef8 Revert DLC cooking + some improvements 3fef85d Merge pull request #51 from pledbrook/patch-1 53cc89e Fix build error when cooking maps 7bc79b5 Switched to DLC cooking functionality (#46) 5b866db Release v1.1.0 1dd9936 Merge pull request #28 from robojumper/remove_verification 1b88ae5 Update README with information about X2ProjectGenerator 60a8235 Rip project file verification out of build_common 6647121 Merge pull request #42 from robojumper/changelog f6b7c1c Changelog the 2nd 702c0f4 Merge pull request #38 from robojumper/profile f126426 Don't set the thread's culture just for a decimal dot 3f602dc Add self-profiling to report step timings ed7a5f2 Merge pull request #31 from robojumper/check-macro-redefs 81c0216 More descriptive macro redefinition error message 0da0304 Merge pull request #39 from robojumper/future-proof adf7f69 Use release tags in installation instructions instead of pulling main 8817f76 Don't delete XComGame\Published in clean.ps1 8da626f Error out on macro redefinitions as a stopgap measure da647e0 Merge pull request #29 from robojumper/changelog f825c12 Merge pull request #27 from robojumper/error-file-line-syntax 06f9d17 Add rolling changelog 0c508eb Use error syntax compatible with both ModBuddy and VS Code git-subtree-dir: .scripts/X2ModBuildCommon git-subtree-split: c7e3945067903304bf74599b763675ffecd43f79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The little yellow '?' only appears for abilities that are not locked. That's fine if you're hiding the locked abilities, but if you have the
RevealAllAbilitiesconfig option set, for example, it makes no sense to disallow players from seeing the extra information about the currently-locked abilities.The text was updated successfully, but these errors were encountered: