Add host to device command timeout #51
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works on my PR board with EV2 Calypso, and it prevents the Kernal crash when LEDs are activated when only USB keyboard is attached. |
…0240911-host-to-device-timeout
|
I made some size optimization, but the feature is still 78 bytes, and the firmware is total 7,132 bytes. Furthermore, I have no real way of testing how well it works. I can say that it doesn't prevent the X16 to work with a PS/2 keyboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a timeout for host to device commands.
The PS/2 clock line is driven by the device. The SMC will currently wait forever until the device has clocked in the byte or bytes.