Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn action into nodejs based action #19

Merged
merged 1 commit into from
Nov 15, 2020
Merged

Turn action into nodejs based action #19

merged 1 commit into from
Nov 15, 2020

Conversation

WyriHaximus
Copy link
Owner

No description provided.

@WyriHaximus WyriHaximus added this to the v2.1.0 milestone Jul 29, 2020
@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch from 2e11508 to 535fc9a Compare July 29, 2020 19:00
@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch 6 times, most recently from e5c7020 to 6813ca7 Compare July 29, 2020 19:33
@boring-cyborg boring-cyborg bot added Dependencies 📦 Pull requests that update a dependency file Docker 🐳 Pull requests that relate to Docker labels Jul 29, 2020
@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch 2 times, most recently from e13d24b to e3ec443 Compare July 29, 2020 19:35
@WyriHaximus WyriHaximus mentioned this pull request Jul 29, 2020
Open
@WyriHaximus WyriHaximus modified the milestones: v2.1.0, v2.2.0 Aug 13, 2020
@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch from 255b31f to bd4c87f Compare September 15, 2020 17:21
accesslint[bot]
accesslint bot suggested changes Sep 15, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

node_modules/glob/README.md
This is a glob implementation in JavaScript. It uses the `minimatch`
library to do its matching.

![](logo/glob.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

node_modules/glob/README.md
npm run prof
```

![](oh-my-glob.gif)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AccessLint How can I ignore this directory?

@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch 6 times, most recently from 631654f to 481e225 Compare September 15, 2020 17:50
@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch 3 times, most recently from 7facde9 to 2cc8ee0 Compare November 14, 2020 21:16
accesslint[bot]
accesslint bot approved these changes Nov 14, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

accesslint[bot]
accesslint bot approved these changes Nov 14, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch from 2cc8ee0 to 4683b06 Compare November 14, 2020 21:50
accesslint[bot]
accesslint bot approved these changes Nov 14, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch from 4683b06 to 6c3cfae Compare November 14, 2020 21:53
accesslint[bot]
accesslint bot approved these changes Nov 14, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch from 6c3cfae to 75fdf86 Compare November 14, 2020 21:57
accesslint[bot]
accesslint bot approved these changes Nov 14, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch from 75fdf86 to b22a8b2 Compare November 14, 2020 22:14
accesslint[bot]
accesslint bot approved these changes Nov 14, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch from b22a8b2 to 696536f Compare November 14, 2020 22:30
accesslint[bot]
accesslint bot approved these changes Nov 14, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch from 696536f to 90643b2 Compare November 14, 2020 22:32
accesslint[bot]
accesslint bot approved these changes Nov 14, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch from 90643b2 to 4a35710 Compare November 14, 2020 22:34
accesslint[bot]
accesslint bot approved these changes Nov 14, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch from 4a35710 to 84e8e5e Compare November 14, 2020 22:38
accesslint[bot]
accesslint bot approved these changes Nov 14, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch from 84e8e5e to 1e7e487 Compare November 14, 2020 22:41
accesslint[bot]
accesslint bot approved these changes Nov 14, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch from 1e7e487 to 41fe6f5 Compare November 14, 2020 22:47
@WyriHaximus WyriHaximus changed the title Use kubeconfig from workspace Turn action into nodejs based action Nov 15, 2020
@WyriHaximus WyriHaximus force-pushed the use-existing-kubeconfig-when-available branch from 41fe6f5 to 32fb1ae Compare November 15, 2020 21:51
accesslint[bot]
accesslint bot approved these changes Nov 15, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@WyriHaximus WyriHaximus merged commit 4fbbdf4 into master Nov 15, 2020
@WyriHaximus WyriHaximus deleted the use-existing-kubeconfig-when-available branch November 15, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint[bot] approved these changes

Assignees
No one assigned
Labels
CI 🚧 Configuration ⚙ Dependencies 📦 Pull requests that update a dependency file Docker 🐳 Pull requests that relate to Docker Feature 🏗 JavaScript 🦏 JSON 👨‍💼 MarkDown 📝 YAML 🍄
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@WyriHaximus