DH 2.0 LODs

[MenacingPerson]

I'd say 21% of the important stuff is done. (Actual progress 4.4%) Not ready to merge yet.

Also, when merging, the wiki needs to be updated:

LOD Status page:

• Removed completely

Install/Setup:

• Must go directly into Wynncraft folder instead of dim_overworld or whatever
• "Multiplayer: Change Server Folder Mode to Name Only"
  • This isn't necessary anymore

(Please squash when merging)

[MenacingPerson]

Corkus

[ShadowCat117]

Not sure if you have but remember to redo the molten heights, sky islands and silent expanse once 2.0.4 is out (or use the beta) as those will have new changes.

The upped render distance will be nice for this too, should make things a little bit faster

[MenacingPerson]

Okay I will have to redo SE

I also am a bit caught up and hence haven't been able to make any progress on this... I guess I'm free today, though, so I'll do this

Edit: I forgot to mention I don't have hero beta, but I guess DH isn't releasing before 2.0.4 does so we do have time

[ShadowCat117]

I might do some then, what version of DH are you using, one of the release candidates or did you build it from the repo?

[MenacingPerson]

They have builds for the very latest commit in their discord

Direct link for 1.19.4 which auto-updates to the latest one: https://gitlab.com/jeseibel/minecraft-lod-mod/-/jobs/artifacts/main/download?job=build:%20[1.19.4]

[MenacingPerson]

I'm gonna boat around the ocean, that shouldn't have gotten any updates, you can push changes to this branch (if you have perms, not sure) and I'll fix the conflicts

[ShadowCat117]

Actually it might just be worth waiting for 2.0.4 so you can do it as don't want me to push some 2.0.4 changes and you accidently overwrite them

[MenacingPerson]

If one of our changes conflict I will prefer yours.. But yeah, best wait for 2.0.4

[obj-obj]

They have builds for the very latest commit in their discord

Direct link for 1.19.4 which auto-updates to the latest one: https://gitlab.com/jeseibel/minecraft-lod-mod/-/jobs/artifacts/main/download?job=build:%20[1.19.4]

Oh there's a CI build? I was compiling it manually...

[obj-obj]

I'm gonna boat around the ocean, that shouldn't have gotten any updates, you can push changes to this branch (if you have perms, not sure) and I'll fix the conflicts

Make sure you're using bedrockify & bedrockwaters

[obj-obj]

If one of our changes conflict I will prefer yours.. But yeah, best wait for 2.0.4

They probably will because git can't diff the compressed LOD files

[MenacingPerson]

Make sure you're using bedrockify & bedrockwaters

Why? Is that still necessary now in 2.0? Crap, didn't know

Time to redo a lot of LODs

[MenacingPerson]

Also, Wynntils updated to 1.20.2 but DH is stuck on 1.20.1, this situation sucks

[obj-obj]

Make sure you're using bedrockify & bedrockwaters

Why? Is that still necessary now in 2.0? Crap, didn't know

Time to redo a lot of LODs

It's not as necessary because 2.0 has that random noise feature, but just do all LODs with those mods from now don't (don't spend a bunch of time redoing the previous ones)

[MenacingPerson]

DH added 1.20.2, I will proceed with more lods tomorrow or the day after

[MenacingPerson]

Wait, Bedrockify and Bedrock Waters aren't on 1.20.2, 🤦

[MenacingPerson]

It seems DH will move to a sqlite database file for LODs. Not sure how good this is for us.

[obj-obj]

It seems DH will move to a sqlite database file for LODs. Not sure how good this is for us.

Bad because before we could at least diff individual files, now we can't diff anything

[MenacingPerson]

Maybe we can bug them for a toggle?

[MenacingPerson]

We are so fucked

Edit: nvm

[obj-obj]

It's fine, we'll just have to do it without being able to diff the files (which means only one person could work on LODs at a time).

Exporting the SQL data probably isn't a good idea because it would make this repo even less accessible for normies (although maybe we could recombine them using GitHub Actions and tell them to download the resulting file).

[obj-obj]

It might be worth making a new repo or branch, actually, as some people might still be using Distant Horizons 1.0.

[MenacingPerson]

These LODs are useless now, they aren't gonna make a converter

Unless someone else does

[obj-obj]

There might be another solution — I saw them working on the ability for the server to send LOD data to the client. Maybe we could campaign for Wynncraft to implement that?

[MenacingPerson]

What about the 2 year interim period before DH implements that? (just kidding)

I mean, that'll be interesting, but we have to see if wynn even implements that

[MenacingPerson]

Time to redo this, SQLite style

[coolGi69]

Ik this is a bit late, but someone on our Discord has made a conversion tool for the old format to sqlite, may help with the transition if you haven't already done it.
https://github.com/gabmontes/dh-lod-to-sqlite

[MenacingPerson]

Oh, cool! Thanks for mentioning that.

Actually I think redoing it after 2.0 release might be better... No telling what changes in between.

@obj-obj BedrockWaters isn't on 1.20.2 yet. Does the 1.20.1 version work?

Bedrock Edition world color noise for grass and water.

I wonder how 2.0 LODs interact with that. I do feel it's a bit opinionated, and with 2.0 water transparency it becomes kind of irrelevant?

Exporting the SQL data probably isn't a good idea because it would make this repo even less accessible for normies (although maybe we could recombine them using GitHub Actions and tell them to download the resulting file).

I think the GH actions idea would make it easier than it is, even currently. That's an upside for sure.

It might be worth making a new repo or branch, actually, as some people might still be using Distant Horizons 1.0.

DH is multi-version. There's no reason to support 1.0 imo.

Gonna try doing LODs again.

[obj-obj]

Oh, cool! Thanks for mentioning that.

Actually I think redoing it after 2.0 release might be better... No telling what changes in between.

@obj-obj BedrockWaters isn't on 1.20.2 yet. Does the 1.20.1 version work?

Bedrock Edition world color noise for grass and water.

I wonder how 2.0 LODs interact with that. I do feel it's a bit opinionated, and with 2.0 water transparency it becomes kind of irrelevant?

Exporting the SQL data probably isn't a good idea because it would make this repo even less accessible for normies (although maybe we could recombine them using GitHub Actions and tell them to download the resulting file).

I think the GH actions idea would make it easier than it is, even currently. That's an upside for sure.

It might be worth making a new repo or branch, actually, as some people might still be using Distant Horizons 1.0.

DH is multi-version. There's no reason to support 1.0 imo.

Gonna try doing LODs again.

Yeah, I think it becomes irrelevant with the water transparency and random noise texture, although it would still look a bit better.

As for the exporting idea, it'd also be annoying to keep manually exporting the data, but I'll see if I can work something out after I'm done with college apps.

I should also probably make a Matrix room, so we don't have to keep talking in PRs and issues. I'll make one and put it in the README right now.