-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AutoRespawn to DeathScreen #792
Added AutoRespawn to DeathScreen #792
Conversation
This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks. Pull requests should be closed if:
|
Still relevant. |
. |
WalkthroughWalkthroughThe changes introduced in the Minecraft mod primarily focus on enhancing the user experience during the death screen phase. A new feature has been added to allow automatic respawning, which can be enabled via a button on the death screen. This feature is controlled by a new Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/main/java/net/wurstclient/mixin/DeathScreenMixin.java (2 hunks)
Additional comments: 4
src/main/java/net/wurstclient/mixin/DeathScreenMixin.java (4)
14-23: Imports look fine and are necessary for the new functionality.
38-45: The
addAutoRespawnButton
method is correctly called during the initialization of the screen. Ensure thatWurstClient.INSTANCE.isEnabled()
is the correct condition to check before adding the button.46-54: The
addAutoRespawnButton
method correctly creates a new button and adds it to the screen. The button's action is set to call thepressAutoRespawn
method.55-61: The
pressAutoRespawn
method toggles theAutoRespawnHack
on and off. Ensure that this is the desired behavior when the button is pressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (2)
- src/main/java/net/wurstclient/hacks/AutoRespawnHack.java (2 hunks)
- src/main/java/net/wurstclient/mixin/DeathScreenMixin.java (2 hunks)
Additional comments: 3
src/main/java/net/wurstclient/hacks/AutoRespawnHack.java (2)
9-29: The new
CheckboxSetting
for the auto respawn button on the death screen is correctly initialized and added to the settings. The description is clear and the default value is set to true, which means the button will be displayed by default.50-54: The
shouldShowButton()
method correctly checks if the client is enabled, the AutoRespawn feature is not already enabled, and the checkbox setting for the button is checked. This ensures that the button is only displayed when it is needed.src/main/java/net/wurstclient/mixin/DeathScreenMixin.java (1)
- 24-25: Ensure that the
DeathScreenMixin
class is correctly extending theScreen
class and that the@Mixin(DeathScreen.class)
annotation is correctly applied. This is crucial for the Mixin to work properly.
Description
Resolves #717
Demonstration
891ee94d910c8c692b3121189b464c04.mp4