-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BarrierESP #790
Added BarrierESP #790
Conversation
This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks. Pull requests should be closed if:
|
Still relevant. |
WalkthroughWalkthroughThe proposed changes introduce a new feature, Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- src/main/resources/assets/wurst/lang/en_us.json
- src/main/resources/wurst.mixins.json
Files selected for processing (3)
- src/main/java/net/wurstclient/hack/HackList.java (1} hunks)
- src/main/java/net/wurstclient/hacks/BarrierEspHack.java (1} hunks)
- src/main/java/net/wurstclient/mixin/ClientWorldMixin.java (1} hunks)
Files skipped from review due to trivial changes (1)
- src/main/java/net/wurstclient/hacks/BarrierEspHack.java
Additional comments: 4
src/main/java/net/wurstclient/hack/HackList.java (1)
- 65-65: The new
BarrierEspHack
is added to theHackList
. Ensure that theBarrierEspHack
class is properly implemented and that it extends theHack
class. Also, verify that theBarrierEspHack
is added to thehax
map in theHackList
constructor.src/main/java/net/wurstclient/mixin/ClientWorldMixin.java (3)
1-7: The copyright notice is updated to include the year 2023, which is correct. Ensure that the copyright notice is updated in all files where necessary.
21-35: The mixin for
ClientWorld
is implemented correctly. ThedoRandomBlockDisplayTicks
method is modified to change the 6th argument toBlocks.BARRIER
when thebarrierEspHack
is enabled. This should change the block display tick for barriers, presumably to render them differently. Ensure that this change does not cause any unexpected side effects in the game, such as rendering issues or performance degradation.30-31: The early return when
barrierEspHack
is not enabled is a good practice to avoid unnecessary computation. However, it's important to ensure that thebarrierEspHack
is properly initialized and can be safely accessed at this point in the code. If there's a chance that it might not be initialized yet, consider adding a null check.- if(!WurstClient.INSTANCE.getHax().barrierEspHack.isEnabled()) + if(WurstClient.INSTANCE.getHax().barrierEspHack == null || !WurstClient.INSTANCE.getHax().barrierEspHack.isEnabled())Committable suggestion (Beta)
private void doRandomBlockDisplayTicks(Args args) { if(WurstClient.INSTANCE.getHax().barrierEspHack == null || !WurstClient.INSTANCE.getHax().barrierEspHack.isEnabled()) return; args.set(5, Blocks.BARRIER); }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/main/java/net/wurstclient/hack/HackList.java (1} hunks)
Additional comments: 1
src/main/java/net/wurstclient/hack/HackList.java (1)
- 68-68: The new
BarrierEspHack
is added to theHackList
. Ensure that theBarrierEspHack
class is properly implemented and that it extends theHack
class. Also, verify that theBarrierEspHack
is added to theTreeMap
in theloadHacks()
method to ensure it is properly initialized and can be retrieved by its name.
Closing this because I've decided to merge #743's BarrierESP instead. Thank you for your effort though! |
Description
Made BarrierESP, resolves #715
Demonstration
27e7f6804e171c06ba32b548019c7224.online-video-cutter.com.mp4