Added an icon when the news was edited #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved to acceptable appearance, need to improve date display in tooltip.
Year update in footer
Wruczek
requested changes
Jun 9, 2024
src/private/templates/index.latte
Outdated
| <div> | ||
| {strtotime($news["added"])|fuzzyDateAbbr} | ||
| {if $news["edited"] !== null} | ||
| <i class="fas fa-pencil-alt mr-0 ml-1 news-edited" data-toggle="tooltip" n:attr="data-date => $news['edited']" data-html="true"></i> |
There was a problem hiding this comment.
- What's the purpose of the
news-editedclass? - Why is the HTML allowed in the tooltip?
There was a problem hiding this comment.
- The
news-editedclass is to make javascript recognize the element. - Deleted.
Wruczek
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved to acceptable appearance than in #218, need to improve date display in tooltip.