Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlled component support #6

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

madox2
Copy link
Contributor

@madox2 madox2 commented Nov 9, 2023

Allows to use segment control as a controlled react component

@WrathChaos WrathChaos self-requested a review November 10, 2023 07:52
@WrathChaos WrathChaos self-assigned this Nov 10, 2023
@WrathChaos
Copy link
Owner

Hey @madox2

It looks good to me :) I will test it today and will release it!

Thank you so much!

@tiste
Copy link

tiste commented Jul 10, 2024

Hey @WrathChaos, is there any chance for this PR to be merged and released?
Thanks a lot.

@WrathChaos
Copy link
Owner

Hello @madox2 , @tiste
Totally my bad. This PR completely lost through my list.

I will test and merge today 🙏

@tiste
Copy link

tiste commented Jul 15, 2024

@WrathChaos thanks a lot!

Copy link
Owner

@WrathChaos WrathChaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you so much! @madox2
Again sorry for very late review

@WrathChaos WrathChaos merged commit d0cdac1 into WrathChaos:master Jul 15, 2024
@WrathChaos
Copy link
Owner

WrathChaos commented Jul 15, 2024

@tiste
Copy link

tiste commented Jul 15, 2024

@WrathChaos could you publish it to npm as well? Thanks again.

@WrathChaos
Copy link
Owner

@tiste Published 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants