Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to support Android 15/API 35 #231

Merged
merged 10 commits into from
Sep 11, 2024
Merged

Conversation

ochalet-wp
Copy link
Contributor

@ochalet-wp ochalet-wp commented Aug 19, 2024

What

  • migrate to Gradle 8 to support running tests and release SDK for Android 15/35
  • fix issue with Dokka plugin following to Gradle build - see this link
  • fix broken UI test
  • upgrade version of Robolectric due to upgrade to Gradle 8 using Java 17
    • we're not using the latest version of Robolectric though because it requires a more recent version of Java
  • fix unit test broken when running on Android versions 30 and above. These versions add an additional LengthFilter to EditText when setting up the inputType, which was failing one of our unit test. The testing logic in the unit test has been changed to cater for that. FYI The filter is designed to limit the length of text to 5,000 characters max. The filters added by the SDK will take precedence and will correctly trim the pan, expiry date and cvc to the max length allowed, so we're safe despite this small difference of implementation
  • broken UI test was failing due to having omitted to stub the service that deals with assets for card brands. As a consequence requests to retrieve card brand images were failing with 404s and the test was failing

How

abaeza-wp
abaeza-wp previously approved these changes Aug 19, 2024
@ochalet-wp ochalet-wp force-pushed the US2012874-android-35 branch from 80511e9 to 9f081cb Compare August 20, 2024 11:07
- Android versions 30 and above add an additional LengthFilter to EditText when setting up the inputType; it is designed to limit the length of text to 5,000 characters max. The filters added by the SDK will take precedence and will correctly trim the pan, expiry date and cvc to the max length allowed, so we're safe despite this small difference of implementation
@ochalet-wp ochalet-wp merged commit 868faf2 into master Sep 11, 2024
12 checks passed
@ochalet-wp ochalet-wp deleted the US2012874-android-35 branch September 11, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants