"Synchronize Order Status" - resolves #135 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce the variable $storeId in the methods getXmlUsername() and getXmlPassword within the specified class. - Incorporate the $storeId parameter into the username and password requests within the inquiry() function of \Sapient\Worldpay\Model\Request\PaymentServiceRequest::inquiry(). - Modify the behaviour of the getStoreId() method in the \Sapient\Worldpay\Model\Order::getStoreId() class to return the Store ID of the order, considering that Payment objects do not have an associated StoreId. - Replace references to $worldPayPayment->getStoreId() with $order->getStoreId() in the getPaymentUpdateXmlForOrder() function of \Sapient\Worldpay\Model\Payment\Service, which invokes the inquiry() function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #135
Introduce the variable $storeId in the methods getXmlUsername() and getXmlPassword within the specified class.
Incorporate the $storeId parameter into the username and password requests within the inquiry() function of \Sapient\Worldpay\Model\Request\PaymentServiceRequest::inquiry().
Modify the behaviour of the getStoreId() method in the \Sapient\Worldpay\Model\Order::getStoreId() class to return the Store ID of the order, considering that Payment objects do not have an associated StoreId.
Replace references to $worldPayPayment->getStoreId() with $order->getStoreId() in the getPaymentUpdateXmlForOrder() function of \Sapient\Worldpay\Model\Payment\Service, which invokes the inquiry() function.