-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VOTable radius/distance/etc columns not working #178
Comments
So I've identified where in the code for VOTable layers this is, and I think I have it working, but it's a bit difficult to test since I don't know what the layer in this example should look like. @pkgw @astrodavid10 do either of you know what this layer should look like? The screenshots below are how I've got it displaying now. I'm a bit concerned about the first screenshot - I don't know a lot about the distribution of known exoplanet locations, but it seemed odd to me that some would be so far off of the galactic plane. |
@Carifio24 Hmmm, I'm not seeing the Kepler cone like I'd expect: |
@astrodavid10 Thanks for the screenshots, and the mention of the Kepler cone - I found what I think was the issue and am now getting the images below from this layer. Looks like the Kepler cone on the left and exoplanets found via microlensing going to the right. |
@Carifio24 Looking much better, thanks! |
@astrodavid10 One more question about this layer - what units should be used for the distance? The |
PS_2021.11.30_19.50.39.xml.zip |
@astrodavid10 Hmm, yeah, it seems that the VOTable viewer just assumes that the distance unit is light years. It looks like the VoTable already stores the unit (as a string) for each column, so it should hopefully be a quick fix. |
@Carifio24 @pkgw Initial testing looks very good to me, thanks! As I pan around the exoplanet data while zoomed out, individual points end up fading (well, it looks like clipping and it is abrupt) in and out. Is there any way to control this such that the whole dataset can be viewed without any part being removed? See also #183 for much larger clipping instances. |
@astrodavid10 This sounds like it could be the "far side visible" setting that I mentioned in the other issue. Do you happen to know how to control that setting in the UI? I think there's almost definitely a way, but I only know how to get at it from Python. |
@pkgw That is what I figured, but as far as I can tell, there is no way to control that parameter through the VOTable UI. The properties button is not functional for VOTables and the VOTable Viewer doesn't have that setting. |
@astrodavid10 Thanks for reporting back. Either Jon or I can take a look through the source code to see if we're missing anything ... and also maybe try a hack to see if the setting is actually relevant anyway. |
As reported by @astrodavid10: if you have a VOTable with 3D data, the distance axis doesn't seem to be working. Everything shows up at R = 1 AU.
Here's a gzipped WWTL sample file that demonstrates the problem: exoplanets_vo_nov_2021.wwtl.gz
The text was updated successfully, but these errors were encountered: