In "Preferences" page, the "Clear Rules" button of blacklist doesn't work

[alfred-zhong]

As I said in the title.
I added several rules in the blacklist and clicked the button. After seconds the plugin restarted and I open the "Preferences" page again. The rules is still there.
Here are the code:

function clearRules() {
    chrome.storage.local.get(['blacklist'], function(items) {
        var blacklist = items['blacklist'];
        blacklist['SITE'] = ['chrome-ui://newtab']
        chrome.storage.local.set({'blacklist':blacklist});
    });
    notie.alert(1, 'Deleted Rules. Restarting WorldBrain...', 2)
    setTimeout(function() {
        chrome.runtime.reload()
    }, 2000);
}

I thought it doesn't work. Right?

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[blackforestboi]

Hello Alfred!

Thanks for notifying us about this issue.

Yes indeed it doesn't work. I just tested it.
We are currently in a refactoring of the code and afterwards this bug should be gone as well.
Sorry for the inconvenience.

What does work though is to remove them separately via the delete button and then press "save"
(Except for the standard ones, which will pop up again - will also be removed with the new update)

Hope that helps!
Oliver

[wimpykid26]

@oliversauter Hello, I would like to work on this if you let me. Just a small question?. Clear rules deletes each and every existing rule right from the 'blacklist'?

[blackforestboi]

Hey @wimpykid26

first of all, thanks a lot for your proactivity and offering your support.

To your question: yes, just delete them all.

Although workflow wise it is to notice, that we are currently in the mode of refactoring and porting all the features the (Re)search-Engine has to the WebMemex code base.

There we don't have the blacklist yet, but are in the process of building it.
Its a little bit bigger task than deleting all the entries, but If you feel comfortable doing that, it would help a lot to push the project further (and making it available for Firefox users).
It's basically the "backend" part of what @aquibm is working on here: WebMemex/webmemex-extension#20

How does that sound?

If good, then it is a good next step to loop in @Treora for the technical specifics.

Thanks again and a great rest of the week!