UIP-1903 Run unit tests in dart2js on CI #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
greglittlefield-wf
force-pushed
the
js_tests
branch
from
91de8dd
to
771ad8f
Compare
greglittlefield-wf
changed the title
greglittlefield-wf
force-pushed
the
js_tests
branch
from
771ad8f
to
50a1e8b
Compare
|
The issue may be with Firefox on Travis... Will try Chromium tomorrow |
Current coverage is 97.44% (diff: 100%)@@ master #28 diff @@
==========================================
Files 27 27
Lines 1286 1286
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1253 1253
Misses 33 33
Partials 0 0
|
greglittlefield-wf
force-pushed
the
js_tests
branch
3 times, most recently
from
559eb58
to
d758bce
Compare
greglittlefield-wf
force-pushed
the
js_tests
branch
2 times, most recently
from
851394d
to
a18acb2
Compare
greglittlefield-wf
changed the title
greglittlefield-wf
force-pushed
the
js_tests
branch
from
df03375
to
ab356ca
Compare
Closed
|
+1 for @rmconsole-wf |
|
+1 |
rmconsole-wf
changed the title
|
QA Resource Approval: +10
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
dart2js-compiled code that deals with JS interop doesn't always behave the same as native Dart code.
We should be running unit tests in dart2js.
How it was fixed:
MirrorsUsedtypo in test, for proper dart2js compilationRun dart2js tests on TravisRun dart2js tests on Smithy in Firefoxfocusmanager.testmodeuser preference proved fruitlessRun dart2js tests on Smithy in Chromegoogle-chromeexecutable that thetestpackage uses to run thechromeplatform, since running in Chromium isn't yet supported (see Add configurable platform support dart-lang/test#391)Testing suggestions:
Potential areas of regression:
Smithy build