-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEDX-1599: fixed validation publish condition #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
bender-wk
changed the title
fixed validation publish condition
FEDX-1599: fixed validation publish condition
Sep 9, 2024
evanweible-wf
approved these changes
Sep 9, 2024
QA +1
|
🚀 @Workiva/release-management-p 🚢 |
rmconsole-wf
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEDX-1599
Pre dart 3, running
dart pub publish --dry-run
would transitively executedart analyze --fatal-infos
under the assumption that all info lints should be resolved before publishing a dart packageThere is an escape hatch
--force
where this check was ignored.This was decided overkill, and just
dart analyze
is now run in dart. This change was applied in dart 3Since we commonly index/publish dart 2 packages in gha-dart-oss, we have to support both approaches, and
--fatal-infos
is a stopgap for the action.As a solution, we've decided to write custom validation steps for dart 2 for the criteria that we want to enforce (specifically the changelog update), and for dart 3, continue to use
dart pub publish --dry-run
On the publish side of things, we need to
--force
publish for dart 2, but dart 3 should be able to publish without issue