Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEDX-1599: fixed validation publish condition #25

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Sep 6, 2024

FEDX-1599

Issue Status

Pre dart 3, running dart pub publish --dry-run would transitively execute dart analyze --fatal-infos under the assumption that all info lints should be resolved before publishing a dart package

There is an escape hatch --force where this check was ignored.

This was decided overkill, and just dart analyze is now run in dart. This change was applied in dart 3

Since we commonly index/publish dart 2 packages in gha-dart-oss, we have to support both approaches, and --fatal-infos is a stopgap for the action.

As a solution, we've decided to write custom validation steps for dart 2 for the criteria that we want to enforce (specifically the changelog update), and for dart 3, continue to use dart pub publish --dry-run

On the publish side of things, we need to --force publish for dart 2, but dart 3 should be able to publish without issue

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review September 9, 2024 15:25
@matthewnitschke-wk matthewnitschke-wk requested a review from a team as a code owner September 9, 2024 15:25
@bender-wk bender-wk changed the title fixed validation publish condition FEDX-1599: fixed validation publish condition Sep 9, 2024
@matthewnitschke-wk
Copy link
Contributor Author

QA +1

@matthewnitschke-wk
Copy link
Contributor Author

🚀 @Workiva/release-management-p 🚢

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit af78217 into master Sep 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants