Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEDX-1472: added build action and fixed publish validate #18

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Aug 21, 2024

FEDX-1472

Issue Status

  • Added a build.yaml action to facilitate providing an sbom as required by our build system
  • Fixed issues with publish validation, where we determine the branch name of the release PR by using the current pubspec.yaml's version and name fields
  • Minor cleanup, thanks to yq being installed everywhere by defailt

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

- name: Install yq
run: |
sudo wget -O /usr/local/bin/yq https://github.com/mikefarah/yq/releases/latest/download/yq_linux_amd64
sudo chmod +x /usr/local/bin/yq
- working-directory: ${{ inputs.package-path }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github runners have this installed by default actions/runner-images#5144

Comment on lines +26 to +27
build:
uses: Workiva/gha-dart-oss/.github/workflows/[email protected]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might add more to this one day, for now it just uploads the sbom

Comment on lines -64 to -65
# only run on release pull requests
if: ${{ startsWith(github.ref, 'refs/head/release') && contains(github.event.sender, 'rmconsole') }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't working, opting for a different approach, calculating the release branchname using the current pubspec.yaml

@matthewnitschke-wk matthewnitschke-wk requested a review from a team August 21, 2024 18:41
@bender-wk bender-wk changed the title added build action and fixed publish validate FEDX-1472: added build action and fixed publish validate Aug 21, 2024
@matthewnitschke-wk
Copy link
Contributor Author

QA +1

  • CI does indeed pass

🚀 @Workiva/release-management-p 🚢

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole4-wk rmconsole4-wk merged commit 87b0e12 into master Aug 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants