Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HY-4965 Turn on strong mode and 2 lint rules #44

Merged
merged 1 commit into from
Jun 15, 2017
Merged

HY-4965 Turn on strong mode and 2 lint rules #44

merged 1 commit into from
Jun 15, 2017

Conversation

robbecker-wf
Copy link
Member

This turns on strong mode and adds 2 lint rules to make sure streams are closed.

@aviary-wf
Copy link

Raven

Number of Findings: 0

@codecov-io
Copy link

codecov-io commented Jun 15, 2017

Codecov Report

Merging #44 into master will decrease coverage by 3.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   96.42%   92.85%   -3.58%     
==========================================
  Files           1        1              
  Lines          28       28              
==========================================
- Hits           27       26       -1     
- Misses          1        2       +1
Impacted Files Coverage Δ
lib/dart_to_js_script_rewriter.dart 92.85% <0%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6bfec8...e2f18f9. Read the comment docs.

@robbecker-wf robbecker-wf changed the title Turn on strong mode and 2 lint rules HY-4965 Turn on strong mode and 2 lint rules Jun 15, 2017
@smaifullerton-wk
Copy link

+1

@maxwellpeterson-wf
Copy link
Member

+10

  • CI passes

@maxwellpeterson-wf
Copy link
Member

QA +1

  • Dev +1's
  • Dev/QA +10 with detail of what was tested
  • Tests created/updated
    • Tooling only
  • All tests pass

@Workiva/release-management-pp

@maxwellpeterson-wf maxwellpeterson-wf merged commit 9c664c4 into Workiva:master Jun 15, 2017
@robbecker-wf robbecker-wf deleted the strong_mode branch June 15, 2017 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants