Playground Previews #118
Merged
Playground Previews #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2024
Closed
dd32
force-pushed
the
try/playground-previewer
branch
from
eb92088 to
54c6c58
Compare
…between variations and the current URL.
bazza
pushed a commit
to WordPress/wordpress.org
that referenced
this pull request
Jun 24, 2024
…views. See r13851. See WordPress/wporg-theme-directory#118. git-svn-id: https://meta.svn.wordpress.org/sites/trunk@13854 74240141-8908-4e6f-9713-ba540dce6ec7
…sult, always be provided to the JS.
|
After this is merged, you'll be able to compare these two urls:
|
dd32
force-pushed
the
try/playground-previewer
branch
from
a092e22 to
92e6cfa
Compare
…This ensures that unset vars are removed.
|
@ryelle This has removed the Is this fine to do? Is there an edge-case that I'm not aware of that we care about? |
I added it assuming we would want to avoid showing non-wporg sites in the previewer, but never followed up to see if that was even possible from the plugin code— so no, I was just trying to be extra-cautious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14
This is a companion to WordPress/wordpress.org#329 exploring adding Theme Previews using Playground to the new theme.
Notes:
This relies upon the above PR for the rest api endpoint.MergedSome changes in the above PR are irrelevant with the new themew.org/themes/$theme/preview/is only used on WordPress.org and is NOT the core previewerwp-themes.comimmediately, and it's probably likely that we'd duplicate the previewer offered here onto wp-themes.com.Took some shortcuts in just deleting some of the previewer code with the overlays to speed up development (I was frustrated with Playground enough, I couldn't determine if playground was at fault or I was using interactivity api wrong)This is actually a very small change code-wise, but the user-experience is not at all ideal IMHO, based on the load times.