Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single theme: Ratings breakdown buggy on Rosetta sites #47

Closed
ryelle opened this issue May 1, 2024 · 0 comments · Fixed by #53
Closed

Single theme: Ratings breakdown buggy on Rosetta sites #47

ryelle opened this issue May 1, 2024 · 0 comments · Fixed by #53
Labels
[Component] Blocks Custom blocks or block variations i18n Translations, RTL issues [Type] Bug Something isn't working

Comments

@ryelle
Copy link
Collaborator

ryelle commented May 1, 2024

The layout of the ratings breakdown is build with display:flex so that each row is a consistent width, the labels being 5em. But "stars" in other languages might be longer than that, and will wrap.

Screenshot 2024-05-01 at 4 17 23 PM

On RTL sites, the bars are not flipped - the red should start from the "stars" label side, and go towards the count.

Screenshot 2024-05-01 at 4 21 29 PM
@ryelle ryelle added [Component] Blocks Custom blocks or block variations [Type] Bug Something isn't working i18n Translations, RTL issues labels May 1, 2024
@ryelle ryelle moved this to 📋 To do in WordPress.org May 1, 2024
@ryelle ryelle moved this from 📋 To do to 🏗 In progress in WordPress.org May 9, 2024
ryelle added a commit that referenced this issue May 9, 2024
@ryelle
Ratings: Use subgrid if available to ensure rating bar alignment
faeea74 
See #47
ryelle added a commit that referenced this issue May 9, 2024
@ryelle
Ratings: Fix alignment of stars and bars on RTL sites
884f35b 
Fixes #47
@ryelle ryelle mentioned this issue May 9, 2024
Merged
@ryelle ryelle closed this as completed in #53 May 9, 2024
ryelle added a commit that referenced this issue May 9, 2024
@ryelle
Tools: Add RTLCSS step to theme build process (#53)
a89dca1 
* Tools: Add RTLCSS step to theme build process

* Ratings: Fix alignment of stars and bars on RTL sites

Fixes #47

* Explain why two configs
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in WordPress.org May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Component] Blocks Custom blocks or block variations i18n Translations, RTL issues [Type] Bug Something isn't working
Projects
WordPress.org
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tools: Add RTLCSS step to theme build process WordPress/wporg-theme-directory
1 participant
@ryelle