Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Blue Bar #32

Closed
coreymckrill opened this issue Sep 14, 2021 · 2 comments · Fixed by #41
Closed

The Blue Bar #32

coreymckrill opened this issue Sep 14, 2021 · 2 comments · Fixed by #41
Assignees
Labels
[Type] Question Needs input from others before actionable

Comments

@coreymckrill
Copy link
Contributor

The Blue Bar is the "local" navigation bar that appears right below the global header. On most views it just looks like this:

blue-bar-1

Breadcrumb on the left, category dropdown on the right.

But sometimes it's expanded so that some or all of the breadcrumb is emphasized in a larger font:

blue-bar-all-posts

blue-bar-podcast

And then, for some category archives, it's a different color:

blue-bar-red

blue-bar-green

blue-bar-charcoal

blue-bar-white

The consistent things are:

  • Breadcrumb
  • Category dropdown
  • The paint stroke on the bottom edge (should be able to make this an SVG and modify its color with CSS)

Does it make sense to try and build this bar as a template part, and contain the logic for the variations within it? Or would it be better to construct the bar in each page-level template separately? (i.e. single.html, page.html, archive.html, etc. all have their own markup for the bar)

@coreymckrill coreymckrill added the [Type] Question Needs input from others before actionable label Sep 14, 2021
@coreymckrill
Copy link
Contributor Author

On the views that have an expanded bar, like the two examples above, the expanded part could potentially be decoupled from the standard part of the blue bar. That way, we could standardize most of it in a template part and then just add the specialized parts to the page-level templates...

@iandunn
Copy link
Member

iandunn commented Sep 16, 2021

decoupled from the standard part

That sounds like a great idea!

coreymckrill added a commit that referenced this issue Sep 28, 2021
Adds the index.html template, along with accompanying template parts and styles. This gets close to matching the All Posts mockup page in the design, but a few things have been omitted:

* The "brush stroke" edge at the bottom of the "All Posts" header. This will be added in when #32 is addressed.
* The "Load More Posts" link has been replaced with query pagination.
* The "Subscribe to WordPress News" box has been left out of the footer, because block templates do not support rendering shortcodes, which is currently the only way to render Jetpack's subscription form.
* Some of the podcast player icons in the WP Briefing footer box are generic links because the Social Icons block does not currently support all the necessary brands/services.

Fixes #22
coreymckrill added a commit that referenced this issue Oct 22, 2021
Introduces the "Blue Bar" or, more accurately, a local header beneath the global header. It includes a simple taxonomy-based breadcrumb on the left and a CSS-based dropdown menu of categories on the right. The color scheme changes ("The Not Blue Bar") for certain categories. The layout responsively handles mobile, tablet, and desktop views.

This also makes the entire site header (including the global header) fixed to the top when not in a narrow mobile viewport, as called for in the design.

Fixes #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Question Needs input from others before actionable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants