Fix/233 revert header footer link fixes #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #233
In #230 we stopped deregistering the global styles in classic themes.
This means we don't need the patched styles for navigation links, that were added to mitigate an issue after some styles moved from CSS to JSON in Gutenberg 13.6.0.
Header styles back:
Footer styles back:
Testing
This can be tested by building
mu-plugins/blocks/global-header-footer/build/style.cssand replacing the file in your sandbox.Check wordpress.org, make.wordpress.org. learn.wordpress.org and ensure the navigation links in the header and footer are white, not blue.