Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show heading link indicator #46

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Always show heading link indicator #46

merged 2 commits into from
Jun 7, 2022

Conversation

iandunn
Copy link
Member

@iandunn iandunn commented May 31, 2022

Only showing it on hover can results in folks not knowing it's there. Hovering isn't a UI concept on mobile devices either, which makes the problem worse. IMO, hovering is best used for design enhancements rather than functionality.

See https://ux.stackexchange.com/questions/20866/ui-hover-focus-to-reveal-controls
See https://ux.stackexchange.com/questions/82015/how-do-users-know-to-hover-over-elements

Fixes #33

@dd32
Copy link
Member

dd32 commented Jun 1, 2022

Personally I'm partial to not showing it, as it's visual clutter to always have it present IMHO.

It's worth noting that this was implemented via https://meta.trac.wordpress.org/ticket/6171 after the lengthy https://make.wordpress.org/docs/2022/02/20/the-hashtag-and-its-future-in-documentation-articles/

It's a hybrid of the Github style (where it only shows the anchor on hover, but also only the anchor is the link) and improving accessibility by linking the entire heading.

@iandunn iandunn force-pushed the 33-link-mystery-meat branch from f3bfc08 to 0b134e4 Compare June 1, 2022 18:00
iandunn added 2 commits June 7, 2022 10:35
Some experiments need to edit this as well, so it should be tracked in the repo.
Only showing it on hover can results in folks not knowing it's there. Hovering isn't a UI concept on mobile devices either, which makes the problem worse. Hovering is best used for design enhancements rather than functionality.

See https://ux.stackexchange.com/questions/20866/ui-hover-focus-to-reveal-controls
See https://ux.stackexchange.com/questions/82015/how-do-users-know-to-hover-over-elements
@renintw renintw force-pushed the 33-link-mystery-meat branch from 0b134e4 to a93ecc4 Compare June 7, 2022 02:35
Copy link
Contributor

@renintw renintw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@renintw renintw merged commit ab94c5e into trunk Jun 7, 2022
@renintw renintw deleted the 33-link-mystery-meat branch June 7, 2022 02:37
ryelle added a commit that referenced this pull request Jun 7, 2022
This plugin was added to git in #46, but it's still technically ignored by git (and IDEs that follow the gitignore). This adds the plugin as an exception, like the theme itself.
@ryelle
Copy link
Contributor

ryelle commented Jun 7, 2022

I added two follow-up commits to handle changes here:

  1. a517ab1 to update the composer lockfile. When I ran composer update, I had to let composer delete the handbook files, then restore them via git.
  2. d206089 to add the handbook plugin to the exceptions in the .gitignore. I'm not totally sure how the files were added without this.

Was the handbook plugin added here because this will be its new source of truth? or is that just temporary to iterate on the sprint faster?

@iandunn
Copy link
Member Author

iandunn commented Jun 8, 2022

Was the handbook plugin added here because this will be its new source of truth? or is that just temporary to iterate on the sprint faster?

I wasn't thinking it'd live here canonically, it just wasn't possible to PR the change w/out a local copy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add anchor indicator
4 participants