-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always show heading link indicator #46
Conversation
dda0324
to
f3bfc08
Compare
Personally I'm partial to not showing it, as it's visual clutter to always have it present IMHO. It's worth noting that this was implemented via https://meta.trac.wordpress.org/ticket/6171 after the lengthy https://make.wordpress.org/docs/2022/02/20/the-hashtag-and-its-future-in-documentation-articles/ It's a hybrid of the Github style (where it only shows the anchor on hover, but also only the anchor is the link) and improving accessibility by linking the entire heading. |
f3bfc08
to
0b134e4
Compare
Some experiments need to edit this as well, so it should be tracked in the repo.
Only showing it on hover can results in folks not knowing it's there. Hovering isn't a UI concept on mobile devices either, which makes the problem worse. Hovering is best used for design enhancements rather than functionality. See https://ux.stackexchange.com/questions/20866/ui-hover-focus-to-reveal-controls See https://ux.stackexchange.com/questions/82015/how-do-users-know-to-hover-over-elements
0b134e4
to
a93ecc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This plugin was added to git in #46, but it's still technically ignored by git (and IDEs that follow the gitignore). This adds the plugin as an exception, like the theme itself.
I added two follow-up commits to handle changes here:
Was the handbook plugin added here because this will be its new source of truth? or is that just temporary to iterate on the sprint faster? |
I wasn't thinking it'd live here canonically, it just wasn't possible to PR the change w/out a local copy |
Only showing it on hover can results in folks not knowing it's there. Hovering isn't a UI concept on mobile devices either, which makes the problem worse. IMO, hovering is best used for design enhancements rather than functionality.
See https://ux.stackexchange.com/questions/20866/ui-hover-focus-to-reveal-controls
See https://ux.stackexchange.com/questions/82015/how-do-users-know-to-hover-over-elements
Fixes #33