-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import use statements section #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some preliminary review notes...
3dde444
to
0eea934
Compare
0eea934
to
9db990a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usual nitpicks ;-) Thanks for working on this @dingo-d !
Changed the code examples to comply with the naming conventions, and removed the usage of |
Co-authored-by: Juliette <[email protected]> Co-authored-by: Gary Jones <[email protected]>
3aae191
to
8320c89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/]
The PR adds rules about import
use
statements in the code and is the continuation of the additions of 'modern' PHP code in the WordPress PHP Coding Standards handbook based on the make post by Juliette Reinders Folmer.I'd hold off of a review until the above PR is merged.