Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import use statements section #98

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Add import use statements section #98

merged 1 commit into from
Aug 21, 2022

Conversation

dingo-d
Copy link
Member

@dingo-d dingo-d commented Aug 12, 2022

The PR adds rules about import use statements in the code and is the continuation of the additions of 'modern' PHP code in the WordPress PHP Coding Standards handbook based on the make post by Juliette Reinders Folmer.

I'd hold off of a review until the above PR is merged.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some preliminary review notes...

wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
@dingo-d dingo-d force-pushed the import-use-statements branch from 3dde444 to 0eea934 Compare August 12, 2022 13:41
@dingo-d dingo-d force-pushed the import-use-statements branch from 0eea934 to 9db990a Compare August 14, 2022 16:35
@dingo-d dingo-d marked this pull request as ready for review August 14, 2022 16:35
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usual nitpicks ;-) Thanks for working on this @dingo-d !

wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
@dingo-d dingo-d requested review from GaryJones and jrfnl August 20, 2022 10:59
@dingo-d
Copy link
Member Author

dingo-d commented Aug 20, 2022

Changed the code examples to comply with the naming conventions, and removed the usage of WordPress as a namespace name (to avoid confusion).

Co-authored-by: Juliette <[email protected]>
Co-authored-by: Gary Jones <[email protected]>
@dingo-d dingo-d force-pushed the import-use-statements branch from 3aae191 to 8320c89 Compare August 20, 2022 12:14
Copy link
Member

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[/]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants