-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic php-cli.js script to replace the PHP terminal command #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Edit: Solved in dacb78a Problem: WASM SAPI is not skipping the shebang line related resources: |
As of d431850 the CLI args are passed to PHP:
|
Relevant WordPress test config setting – otherwise the phpunit command won't work: define( 'WP_PHP_BINARY', 'PHP=8.0 <path to php-cli.js>' ); |
This was referenced Jan 24, 2023
#119 does everything this PR does and more. I'll close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 Work in Progress 🚧
This PR explores a generic
php-cli.js
script that could eventually be ran asnpx php
and provide a viable replacement for the system-native PHP CLI package.For now, it's hardwired to run phpunit from
wordpress-develop
and does a pretty good job: