Cache count_user_posts()
#7993
Cache count_user_posts()
#7993
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jonnynews. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| add_action( 'attachment_updated', '_clear_user_posts_count_cache_on_author_change', 10, 3 ); | ||
| add_action( 'post_updated', '_clear_user_posts_count_cache_on_author_change', 10, 3 ); |
There was a problem hiding this comment.
Did you consider using clean_post_cache. Lots of plugins do manaul sql updates and then call this function.
There was a problem hiding this comment.
I did, but I think it runs too often. No reason to clear the cache unless the post status or author changes, or if the post is deleted.
There was a problem hiding this comment.
Maybe I can add some conditions though
There was a problem hiding this comment.
If you look at this list, there are a number of popular plugins that use that function.
https://wpdirectory.net/search/01JEXQH4XW97YT5CZM38TKDPJB
Including
- Yoast SEO
- WooCommerce
- Jetpack
- Elementor
and other very popular plugins. Sadly I think we HAVE to use this hook.
There was a problem hiding this comment.
Still only half of the equation.
There was a problem hiding this comment.
Still only half of the equation.
Can you expand of this, I am not sure I know what you mean?
desrosj
added
the
props-bot
github-actions
bot
removed
the
props-bot
This is a refresh of the previous patches & tests on the ticket. More work & testing is needed though.
One big blocker right now is that the count query in
get_posts_by_author_sql()is based on the current user and its capabilities. So that probably needs a second cache key. That's why previous patches used a hash of that where clause as part of the cache key when doing the count. But you need the same key also when clearing the cache.Right now the one test is failing because of the incomplete caching.
Trac ticket: https://core.trac.wordpress.org/ticket/39242
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.