-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: limit uploads to supported mime types #7629
base: trunk
Are you sure you want to change the base?
Editor: limit uploads to supported mime types #7629
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Previously this was #6531, in this PR I expanded it to include checks for all mime types, so this now covers heic uploads as well. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
@@ -211,10 +211,19 @@ function get_default_block_editor_settings() { | |||
); | |||
} | |||
|
|||
$allowed_mime_types = get_allowed_mime_types(); | |||
|
|||
// Iterate through mime types and check if they are supported by the image editor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Iterate through mime types and check if they are supported by the image editor. | |
// Iterate through mime types and remove those unsupported by the image editor. |
A little nitpicky, but imho that one is more into the point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically flawless, I suggested a minor doc change to be more precise.
Trac ticket: https://core.trac.wordpress.org/ticket/61167