Fix error with Heartbeat settings in edit-form-blocks.php

[azaozz]

Seems this should be running on DOM ready.

Trac ticket: https://core.trac.wordpress.org/ticket/61960

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props azaozz, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[peterwilsoncc]

Thanks @azaozz, this fixes the issue.

As a minor change request: Are you able to add dom ready as a dependency to the heartbeat to ensure future changes to the order of operations and/or block editor script dependencies don't result in the interval going back to 15 seconds? You'll be able to remove the test domReady is defined too.

As some rubber ducking on an alternative: could it be worth using a null source to ensure the dependency changes only affect the block editor. Something like:

// Set Heartbeat interval to 10 seconds, used to refresh post locks.
wp_register_script( 'wp-heartbeat-block-editor-interval', false, array( 'heartbeat', 'wp-dom-ready' ), false, array( 'in_footer' => 'true' ) );
wp_add_inline_script(
	'wp-heartbeat-block-editor-interval',
	'window.wp.domReady( function() {
		if ( window.wp.heartbeat ) {
			window.wp.heartbeat.interval( 10 );
		}
	} );',
	'after'
);
wp_enqueue_script( 'wp-heartbeat-block-editor-interval' );

[peterwilsoncc]

Changing this to after will negate the need to check heartbeat is defined, the script defines it as the script loads.

wordpress-develop/src/js/_enqueues/wp/heartbeat.js

Lines 892 to 898 in 4712210

	/**
	* Contains the Heartbeat API.
	*
	* @namespace wp.heartbeat
	* @type {Heartbeat}
	*/
	window.wp.heartbeat = new Heartbeat();

[azaozz]

Are you able to add dom ready as a dependency to the heartbeat

Sure.

Changing this to after will negate the need to check heartbeat is defined

Right. Seems the before/after wouldn't make much difference as they will not be outputted if heartbeat.js is not outputted. But you're right, this patch/PR is way too cautious, was mostly to confirm it works now. It can be written better as both window.wp and window.wp.heartbeat will be defined in all cases. Fixing..

[azaozz]

Simplified and switched to using jQuery for DOM ready. Heartbeat depends on it already, seems no point in adding another dependency.

[peterwilsoncc]

Thanks boss, looks good to me.

seems no point in adding another dependency.

Yea, that seems sensible. ;)

[azaozz]

Committed: https://core.trac.wordpress.org/changeset/59092.