App Passwords: Don't prevent non-unique App Password names.

src/wp-includes/class-wp-application-passwords.php

@@ -94,10 +94,6 @@ public static function create_new_application_password( $user_id, $args = array(
 			return new WP_Error( 'application_password_empty_name', __( 'An application name is required to create an application password.' ), array( 'status' => 400 ) );
 		}
 
-		if ( self::application_name_exists_for_user( $user_id, $args['name'] ) ) {
-			return new WP_Error( 'application_password_duplicate_name', __( 'Each application name should be unique.' ), array( 'status' => 409 ) );
-		}
-
 		$new_password    = wp_generate_password( static::PW_LENGTH, false );
 		$hashed_password = wp_hash_password( $new_password );
 

tests/e2e/specs/profile/applications-passwords.test.js

@@ -35,23 +35,6 @@
 		);
 	} );
 
-	test('should not allow to create two applications passwords with the same name', async ( {
-		page,
-		applicationPasswords
-	} ) => {
-		await applicationPasswords.create();
-		await applicationPasswords.create();
-
-		const errorMessage = page.getByRole( 'alert' );
-
-		await expect( errorMessage ).toHaveClass( /notice-error/ );
-		await expect(
-			errorMessage
-		).toContainText(
-			'Each application name should be unique.'
-		);
-	});
-
 	test( 'should correctly revoke a single application password', async ( {
 		page,
 		applicationPasswords
@@ -112,7 +95,7 @@
 		const newPasswordField = this.page.getByRole( 'textbox', { name: 'New Application Password Name' } );
 		await expect( newPasswordField ).toBeVisible();
 		await newPasswordField.fill( applicationName );
 
 		await this.page.getByRole( 'button', { name: 'Add New Application Password' } ).click();
 		await expect( this.page.getByRole( 'alert' ) ).toBeVisible();
 	}

tests/phpunit/tests/rest-api/application-passwords.php

@@ -77,14 +77,6 @@ public function data_create_new_application_password_validation() {
 				),
 				'args'     => array( 'name' => '<script>console.log("Hello")</script>' ),
 			),
-			'application_password_duplicate_name when name exists' => array(
-				'expected' => array(
-					'error_code'    => 'application_password_duplicate_name',
-					'error_message' => 'Each application name should be unique.',
-				),
-				'args'     => array( 'name' => 'test2' ),
-				'names'    => array( 'test1', 'test2' ),
-			),
 		);
 	}
 
@@ -196,4 +188,14 @@ public function data_update_application_password() {
 			),
 		);
 	}
+
+	/**
+	 * @ticket 51941
+	 */
+	public function test_can_create_duplicate_app_password_names() {
+		$created = WP_Application_Passwords::create_new_application_password( self::$user_id, array( 'name' => 'My App' ) );
+		$this->assertNotWPError( $created, 'First attempt to create an application password should not return an error' );
+		$created = WP_Application_Passwords::create_new_application_password( self::$user_id, array( 'name' => 'My App' ) );
+		$this->assertNotWPError( $created, 'Second attempt to create an application password should not return an error' );
+	}
 }