Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Fatal Errors: don't assume set_ini() exists #7352

Open
wants to merge 14 commits into
base: trunk
Choose a base branch
from
Open

fix Fatal Errors: don't assume set_ini() exists #7352

wants to merge 14 commits into from
+39 −15

Conversation

maltfield
Copy link

@maltfield maltfield commented Sep 13, 2024 •
edited
Loading

Trac ticket:

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions GitHub Actions
Copy link

Hi @maltfield! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @maltfield.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aristath.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

aristath
aristath requested changes Sep 17, 2024
View reviewed changes
src/wp-admin/plugins.php Outdated Show resolved Hide resolved
src/wp-admin/update.php Outdated Show resolved Hide resolved
src/wp-includes/PHPMailer/PHPMailer.php Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should make any changes to this file directly, as it's a 3rd-party library... 🤔

src/wp-includes/default-constants.php Outdated Show resolved Hide resolved
src/wp-includes/functions.php Outdated Show resolved Hide resolved
src/wp-includes/load.php Outdated Show resolved Hide resolved
src/wp-includes/load.php Outdated Show resolved Hide resolved
src/wp-includes/load.php Outdated Show resolved Hide resolved
src/wp-includes/load.php Outdated Show resolved Hide resolved
src/wp-includes/pomo/po.php Outdated Show resolved Hide resolved
maltfield and others added 13 commits September 17, 2024 10:08
@maltfield @aristath
Update src/wp-admin/plugins.php
3737c62 
Co-authored-by: Ari Stathopoulos <[email protected]>
@maltfield @aristath
Update src/wp-admin/update.php
d45a310 
Co-authored-by: Ari Stathopoulos <[email protected]>
@maltfield @aristath
Update src/wp-includes/default-constants.php
9173f7d 
Co-authored-by: Ari Stathopoulos <[email protected]>
@maltfield @aristath
Update src/wp-includes/load.php
0461175 
Co-authored-by: Ari Stathopoulos <[email protected]>
@maltfield @aristath
Update src/wp-includes/functions.php
faa1318 
Co-authored-by: Ari Stathopoulos <[email protected]>
@maltfield @aristath
Update src/wp-includes/pomo/po.php
a5a5a23 
Co-authored-by: Ari Stathopoulos <[email protected]>
@maltfield @aristath
Update src/wp-includes/load.php
bbaf5a8 
Co-authored-by: Ari Stathopoulos <[email protected]>
@maltfield @aristath
Update src/wp-includes/load.php
cd2ed10 
Co-authored-by: Ari Stathopoulos <[email protected]>
@maltfield @aristath
Update src/wp-includes/load.php
6982f7a 
Co-authored-by: Ari Stathopoulos <[email protected]>
@maltfield @aristath
Update src/wp-includes/functions.php
0ccda9e 
Co-authored-by: Ari Stathopoulos <[email protected]>
@maltfield
Merge branch 'WordPress:trunk' into trunk
48d5dab
@maltfield
check to see chmod exists before using it
d4f07bd 
this commit fixes bug #62693, which prevents users from uploading media to wordpress because wordpress throws a fatal error when calling 'chmod' on servers with php.ini security-hardened following best practices, which disables dangerous functions, such as exec(), chmod(), etc.

 * https://core.trac.wordpress.org/ticket/62693

this change doesn't make the assumption that the chmod() function is available for use; it checks it first with function_exists()
@maltfield
check to see chmod exists before using it
9e599f4 
this commit fixes bug #62693, which prevents users from uploading media to wordpress because wordpress throws a fatal error when calling 'chmod' on servers with php.ini security-hardened following best practices, which disables dangerous functions, such as exec(), chmod(), etc.

 * https://core.trac.wordpress.org/ticket/62693

this change doesn't make the assumption that the chmod() function is available for use; it checks it first with function_exists()
@maltfield
Copy link
Author

I couldn't figure out how to tell GitHub to make a different PR for this and the new bug:

So both of these bug fixes are combined into one PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maltfield @aristath