mirrored from git://develop.git.wordpress.org/
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Block Metadata PHP Cache to Third-Party Blocks #7303
Closed
Closed
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
5f5fbd2
add WP_Block_Metadata_Registry, allow blocks to bypass block.json par…
mreishus 8a28294
update
mreishus 8ca134d
add metadata_source
mreishus 270d784
formatting fixes
mreishus 9376059
add trailing comma
mreishus d503724
horizontal align
mreishus c5b81f5
remove namespace
mreishus a914dee
remove third parameter
mreishus a25c643
make static
mreishus bb6fec3
allow metadata source to be passed to register_block_type
mreishus c7cb99a
fix alignment
mreishus 14b1c56
undo everything
mreishus f75c4fd
new implementation
mreishus 12c01b8
add tests
mreishus ae81aa6
align equals
mreishus 9779e78
fix broken test
mreishus 15c51a6
move the collection and block identification logic to the WP_Block_Me…
mreishus 2c3630b
lint fix
mreishus 1fa5877
guard against incorrect paths
mreishus a4c1455
indent fix
mreishus 26c6b0c
lint fix
mreishus 191c553
Call into WP_Block_Metadata_Registry:: looking for metadata only once…
mreishus 43915a8
add $last_matched_collection
mreishus abbf5d5
align equals
mreishus 8d7badc
update comments
mreishus 0ca6c93
variable rename
mreishus 70431b2
update comment
mreishus 504e09c
remove private constructor
mreishus db5dee2
add _doing_it_wrong calls
mreishus 61acb57
fix broken tests
mreishus 4cd8fcc
Remove $identifier_callback option
mreishus 3b13d45
comment updates
mreishus 396e6c9
make default_identifier_callback private
mreishus 78a46fb
standardize _doing_it_wrong messages
mreishus d948dde
reorganize top of register_block_type_from_metadata
mreishus 15353f4
fix one more since tag
mreishus a3b73f3
update comment
mreishus 3a5ad69
fix elseif
mreishus 3b70192
default_identifier_callback: Use str_ends_with and return early if empty
mreishus 166ed80
Update src/wp-includes/blocks.php
mreishus 63772f1
Add Tests_Blocks_RegisterBlockTypeFromMetadataWithRegistry
mreishus b069b60
retab
mreishus 2e44638
add trailing commas
mreishus 779a2e8
align arrows and equals
mreishus a9d6eb9
let core blocks skip the file_exists check
mreishus a257e6f
minor change to force test rerun
mreishus 3e4d5b6
Revert "minor change to force test rerun"
mreishus 3a55080
register_collection: Use static variables to reduce calls to wp_norma…
mreishus 6584762
extract to get_include_path and get_plugin_dir functions
mreishus f2e31d7
allow registering for themes
mreishus 2d7533b
stop someone from registering the entire themes directory
mreishus 498bbba
get_include_path -> get_wpinc_dir
mreishus c23cf0a
Revert "stop someone from registering the entire themes directory"
mreishus 7fd96b4
Revert "allow registering for themes"
mreishus 9aa134d
Merge branch 'trunk' into add/metadata-register
felixarntz a323758
Rename wpinc_path to wpinc_dir and clarify docs.
felixarntz 6467b31
Use isset instead of empty.
felixarntz 31809da
Make conditional logic more intuitive.
felixarntz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix one more since tag
- Loading branch information
commit 15353f42c3fd84f6f0f47556dfce51624611bb77
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So my hope for the future is the following to be possible in Gutenberg:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right! I think technically that already should be possible once this PR lands? 🤔