-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elements: Avoid specificity bump for top-level element-only selectors #7012
Elements: Avoid specificity bump for top-level element-only selectors #7012
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is testing well for me. At first I ran into a bug that turns out is unrelated to this change, and has a POC fix over in #7017. With that applied locally, the testing steps are working nicely for me on the site frontend, and the code change matches what merged in Gutenberg over in WordPress/gutenberg#63403
Applied the diff of this PR to the 6.6 branch and followed the testing instructions. Looks ok 👍 |
Committed to trunk in r58749 and re-opened https://core.trac.wordpress.org/ticket/61660 to request backport to 6.6 branch. |
This PR backports the PHP changes from WordPress/gutenberg#63403
These changes prevent issues caused by a bump in CSS specificity for top-level element-only global element styles. See the linked PR and original issue for further details.
Trac ticket: https://core.trac.wordpress.org/ticket/61630
Trac ticket: https://core.trac.wordpress.org/ticket/61660
Testing Instructions
Please note: JS package updates are required for the issue to be resolved in the editor. When testing, make the relevant changes in the editor and then confirm correct styles on the frontend
header nav ul li a
. You'll need to toggle the custom HTML block preview for it to pick up the custom CSS.styles.elements
andstyles.blocks.core/group.elements.link
styles. The following snippets can be used to create theme.json partial files within the theme's/styles
directory which will then be registered as block style variations.Example Block Style Variation Partials
0-1-0
specificityScreenshots
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.