-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MySQL 8.4 LTS testing. #6680
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Co-authored-by: Aaron Jorbin <[email protected]>
Some other clean up as well.
@aristath I saw that you self assigned to perform a review. I think this is getting really close, so wanted to make sure you had a chance to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @desrosj!
Added a comment 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and all the previous comments have been addressed.
Reminder to not include the change to using the desrosj
repo and branch for the reusable workflows.
MySQL 8.4 was released on April 30, 2024 and is the latest LTS version of MySQL.
This adds MySQL testing to the GitHub Actions and eliminates the MySQL innovation releases since they are no longer supported or receiving security releases.
In order to properly test and support MySQL 8.4 in the local Docker environment while still allowing PHP 7.2 and 7.3 to be used, some changes were required to dynamically determine which authentication plugin to use and any additional configuration that is required.
This means that instead of blanket enforcing
mysql_native_password
, the environment will now always use the default unless that's unsupported (likecaching_sha2_password
for PHP 7.2/7.3).Trac ticket: https://core.trac.wordpress.org/ticket/61218
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.