-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KSES: Allow leading trailing double hyphen in data attributes #6598
Conversation
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a step improvement this is helpful. I'm leaving #6429 open, but I don't want it to be a blocker for opening up this patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected.
Expand allowable set of custom data attribute names to include those containing leading, trailing, and double `-` characters. Previously, WordPress was removing data attributes that are used in the Interactivity API. By allowing these additional custom data attributes, the related Interactivity API directives will preserve through `kses`. For example, the Interactivity API frequently relies on custom data attributes such as `data-wp-on--click="..."`. The change in [43981] would strip these out of the processed HTML, however. Developed in #6598 Discussed in https://core.trac.wordpress.org/ticket/61052 Props cbravobernal, dmsnell, gziolo, jonsurrell. Follow-up to [43981]. Fixes #61052. git-svn-id: https://develop.svn.wordpress.org/trunk@58294 602fd350-edb4-49c9-b593-d223f7449a82
Expand allowable set of custom data attribute names to include those containing leading, trailing, and double `-` characters. Previously, WordPress was removing data attributes that are used in the Interactivity API. By allowing these additional custom data attributes, the related Interactivity API directives will preserve through `kses`. For example, the Interactivity API frequently relies on custom data attributes such as `data-wp-on--click="..."`. The change in [43981] would strip these out of the processed HTML, however. Developed in WordPress/wordpress-develop#6598 Discussed in https://core.trac.wordpress.org/ticket/61052 Props cbravobernal, dmsnell, gziolo, jonsurrell. Follow-up to [43981]. Fixes #61052. Built from https://develop.svn.wordpress.org/trunk@58294 git-svn-id: http://core.svn.wordpress.org/trunk@57754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Expand allowable set of custom data attribute names to include those containing leading, trailing, and double `-` characters. Previously, WordPress was removing data attributes that are used in the Interactivity API. By allowing these additional custom data attributes, the related Interactivity API directives will preserve through `kses`. For example, the Interactivity API frequently relies on custom data attributes such as `data-wp-on--click="..."`. The change in [43981] would strip these out of the processed HTML, however. Developed in WordPress/wordpress-develop#6598 Discussed in https://core.trac.wordpress.org/ticket/61052 Props cbravobernal, dmsnell, gziolo, jonsurrell. Follow-up to [43981]. Fixes #61052. Built from https://develop.svn.wordpress.org/trunk@58294 git-svn-id: https://core.svn.wordpress.org/trunk@57754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Trac ticket: Core-61052
Allow data attrbitues with leading, trailing, and double
-
in the attribute name.This relaxes the hyphen restriction introduced in https://core.trac.wordpress.org/changeset/43981. It is intended to be a simple change to allow data attributes used frequently by the Interactivity API like
data-wp-on--click="…"
.It is not a substitute for #6429. I'd like to see that move ahead the data attribute restrictions further relaxed to align with what's allowed by the specification. This is intended to be a smaller and easier change to solve the immediate need that can be landed without too much difficulty.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.