Add Script Module hooks registration on admin_footer #6452
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Works as expected. Screen.Recording.2024-05-08.at.13.05.12.mov |
| add_action( 'admin_footer', array( $this, 'print_import_map' ) ); | ||
| add_action( 'admin_footer', array( $this, 'print_enqueued_script_modules' ) ); | ||
| add_action( 'admin_footer', array( $this, 'print_script_module_preloads' ) ); |
There was a problem hiding this comment.
Just like in #6453, we can use admin_print_footer_scripts which is a bit later and probably more appropriate.
|
Committed with https://core.trac.wordpress.org/changeset/58126. |
Trac ticket: https://core.trac.wordpress.org/ticket/61086
This can be tested with #6453, this change is necessary for #6453 to work correctly.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.