Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script Modules API #5818

Closed
wants to merge 36 commits into from
Closed

Script Modules API #5818

wants to merge 36 commits into from

Commits on Dec 22, 2023

  1. Modules API: Initial version

    @luisherranz
    luisherranz committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    8347e8b View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2023

  1. Move actions to default-filters.php

    @luisherranz
    luisherranz committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    27ba624 View commit details
    Browse the repository at this point in the history

  2. Move module functions to its own file

    @luisherranz
    luisherranz committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    156eb58 View commit details
    Browse the repository at this point in the history

  3. Use wp_print_inline_script_tag to print import map

    @luisherranz
    luisherranz committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    bbae17c View commit details
    Browse the repository at this point in the history

  4. Divide tests into two files and improve covers

    @luisherranz
    luisherranz committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    76e8726 View commit details
    Browse the repository at this point in the history

  5. Switch to ReflectionProperty to setStaticPropertyValue

    @luisherranz
    luisherranz committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    f0fa726 View commit details
    Browse the repository at this point in the history

  6. Refactor the tests set_up

    @luisherranz
    luisherranz committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    f13a068 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Test that static dependencies of dynamic dependencies are not preloaded

    @luisherranz
    luisherranz committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    ef978d8 View commit details
    Browse the repository at this point in the history

  2. Add since to main class DocBlock 

    Co-authored-by: Greg Ziółkowski <[email protected]>
    @luisherranz @gziolo
    luisherranz and gziolo authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    212cdac View commit details
    Browse the repository at this point in the history

  3. Change assertEquals with custom ones

    @luisherranz
    luisherranz committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    e644da8 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Avoid static methods and rely on instances

    @luisherranz
    luisherranz committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    1aa45a6 View commit details
    Browse the repository at this point in the history

  2. Introduce wrapper functions for printing methods 

    To avoid instantiating the class early in the WordPress bootstrap.
    @luisherranz
    luisherranz committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    eaaa563 View commit details
    Browse the repository at this point in the history

  3. Remove space between @SInCE and @var in class properties

    @luisherranz
    luisherranz committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    e30c8e9 View commit details
    Browse the repository at this point in the history

  4. Test that version is propagated correctly

    @luisherranz
    luisherranz committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    a13bc87 View commit details
    Browse the repository at this point in the history

  5. Cap parameter descriptions to 120 chars

    @luisherranz
    luisherranz committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    67f3900 View commit details
    Browse the repository at this point in the history

  6. Turn $enqueued_before_registered into a map

    @luisherranz
    luisherranz committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    66987f0 View commit details
    Browse the repository at this point in the history

  7. Remove SCRIPT_DEBUG support

    @luisherranz
    luisherranz committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    fda294d View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Rename enqueued to enqueue

    @luisherranz
    luisherranz committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    c94568d View commit details
    Browse the repository at this point in the history

  2. Add failing test for multiple prints of enqueued modules

    @luisherranz
    luisherranz committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    2eaf6ea View commit details
    Browse the repository at this point in the history

  3. Fix test

    @luisherranz
    luisherranz committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    4dcfc88 View commit details
    Browse the repository at this point in the history

  4. Add failing test for multiple prints of preloaded modules

    @luisherranz
    luisherranz committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a4f9812 View commit details
    Browse the repository at this point in the history

  5. Fix the test

    @luisherranz
    luisherranz committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    89a82fc View commit details
    Browse the repository at this point in the history

  6. Print enqueued and preloaded modules in the head and footer

    @luisherranz
    luisherranz committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    9f08176 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Move the hooks to the class

    @luisherranz
    luisherranz committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    4b815bc View commit details
    Browse the repository at this point in the history

  2. Rename type key to import 

    It's semantically more correct and it liberates
the `type` key to be used by other purposes,
like specifying between `script`, `css` or
`json`.
    @luisherranz
    luisherranz committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    bc8c633 View commit details
    Browse the repository at this point in the history

  3. Add _doing_it_wrongs 

    Co-authored-by: Weston Ruter <[email protected]>
    @luisherranz @westonruter
    luisherranz and westonruter authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    b3554d6 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/add/modules-api' into add/module… 

    …s-api
    @luisherranz
    luisherranz committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    35a9402 View commit details
    Browse the repository at this point in the history

  5. Improve @param type of $deps

    @luisherranz
    luisherranz committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    df73485 View commit details
    Browse the repository at this point in the history

  6. Indicate how the new print functions work

    @luisherranz
    luisherranz committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    8fd7501 View commit details
    Browse the repository at this point in the history

  7. Reorder methods

    @luisherranz
    luisherranz committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    506784a View commit details
    Browse the repository at this point in the history

  8. Test an empty import map

    @luisherranz
    luisherranz committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    168ae91 View commit details
    Browse the repository at this point in the history

  9. Replace get_version_query_string with get_versioned_src

    @luisherranz
    luisherranz committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    1df672d View commit details
    Browse the repository at this point in the history

  10. Use esc_url instead of esc_attr for link's href attribute

    @luisherranz
    luisherranz committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    0cb7f1b View commit details
    Browse the repository at this point in the history

  11. Add suffixes to the ids and an id to the import map

    @luisherranz
    luisherranz committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    834693d View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Rename class to WP_Script_Modules

    @luisherranz
    luisherranz committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b2ff803 View commit details
    Browse the repository at this point in the history

  2. Allow wp_enqueue_module to also register modules

    @luisherranz
    luisherranz committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    adb5913 View commit details
    Browse the repository at this point in the history