Twenty Twenty-Three: Set fixed max height for featured images #4821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noting that we can ideally get this in before the Product Demo on July 27th as we'll use the TT3 theme then. |
|
Thanks a lot @mikachan LGTM Here are some huge GIFs 🎉 Before
After
|
ramonjd
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the height of the featured images in the Archive, Home, Index, and Search templates from
max(15vw, 30vh)toclamp(15vw, 30vh, 400px). This is to set a maximum fixed-pixel height on the featured images, to prevent them from causing an ever-expanding iFrame height. Please see WordPress/gutenberg#52297 for more details.Trac ticket: https://core.trac.wordpress.org/ticket/58766
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.