Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AVIF support #4612

Closed

Conversation

adamsilverstein
Copy link
Member

@adamsilverstein adamsilverstein commented Jun 13, 2023

Trac ticket: https://core.trac.wordpress.org/ticket/51228


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@adamsilverstein adamsilverstein marked this pull request as ready for review January 9, 2024 16:30
src/wp-includes/functions.php Outdated Show resolved Hide resolved
@adamsilverstein
Copy link
Member Author

adamsilverstein commented Jan 24, 2024

@mukeshpanchal27 - note that it looks like tests broke in 49f4278 (#4612). those variables were used on the next line where the line return compact( 'width', 'height', 'type' ); uses a weird syntax to reference them.

Anyway, that function was poorly structured and had an inconsistent return structure; it already had a default return value set later in the function so I moved that up and return it when the mime type isn't avif in b492dbf (#4612)

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adamsilverstein, for the update. I've left some nit-pick feedback and suggestions. Other than that, looks good to me.

phpcs.xml.dist Outdated Show resolved Hide resolved
src/wp-includes/class-wp-image-editor-imagick.php Outdated Show resolved Hide resolved
src/wp-includes/media.php Outdated Show resolved Hide resolved
src/wp-includes/media.php Outdated Show resolved Hide resolved
adamsilverstein and others added 5 commits January 29, 2024 09:23
docblock improvement

Co-authored-by: Mukesh Panchal <[email protected]>
docblock cleanup

Co-authored-by: Mukesh Panchal <[email protected]>
remove inadvertent exclude path for phpcs

Co-authored-by: Mukesh Panchal <[email protected]>
@WordPress WordPress deleted a comment from github-actions bot Jan 29, 2024
@adamsilverstein
Copy link
Member Author

Thanks, @adamsilverstein, for the update. I've left some nit-pick feedback and suggestions. Other than that, looks good to me.

Thanks for the careful review and suggestions, I have accepted your suggestions.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link

github-actions bot commented Feb 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @y-guyon.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: adamsilverstein, mukesh27, swissspidy.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: y-guyon.

Co-authored-by: adamsilverstein <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: swissspidy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@adamsilverstein
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants