-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AVIF support #4612
Add AVIF support #4612
Conversation
341a9e3
to
b96bb09
Compare
# Conflicts: # phpcs.xml.dist
note: the file type is not determined by this function as with webp, but the sizes are returned correctly.
…allback for AVIFs
this function is designed to work regardless of server support for WebP so let’s test it that way
…after PHP 8.2 is the minimum version for WordPress
Co-authored-by: Mukesh Panchal <[email protected]>
Co-authored-by: Mukesh Panchal <[email protected]>
@mukeshpanchal27 - note that it looks like tests broke in Anyway, that function was poorly structured and had an inconsistent return structure; it already had a default return value set later in the function so I moved that up and return it when the mime type isn't avif in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @adamsilverstein, for the update. I've left some nit-pick feedback and suggestions. Other than that, looks good to me.
docblock improvement Co-authored-by: Mukesh Panchal <[email protected]>
Co-authored-by: Mukesh Panchal <[email protected]>
docblock cleanup Co-authored-by: Mukesh Panchal <[email protected]>
remove inadvertent exclude path for phpcs Co-authored-by: Mukesh Panchal <[email protected]>
Thanks for the careful review and suggestions, I have accepted your suggestions. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @y-guyon. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core SVNIf you're a Core Committer, use this list when committing to
GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac ticket: https://core.trac.wordpress.org/ticket/51228
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.