-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance code quality related to WP_Theme_JSON::append_to_selector()
calls by introducing prepend_to_selector()
#4380
Conversation
Hi Felix, would you be able to send this PR to Gutenberg? That's where the source of truth for this code lives. This makes sense from a "code wise" perspective to me. It'd be good to engage the original authors/reviewers for help as well, so the pattern is more widely shared. |
@oandregal Makes sense. I just opened WordPress/gutenberg#50266 :) |
Closing this in favor of WordPress/gutenberg#50266 |
Hi! I see the respective change in Gutenberg has been merged, but unless I'm mistaken this PR will still be needed to make the update in core? Shall we reopen it? |
Thanks @tellthemachines, good point. I thought this was gonna be backported together with #4412, but I've reopened this PR and updated it against |
Committed in https://core.trac.wordpress.org/changeset/55950. |
Backport of WordPress/gutenberg#50266
Trac ticket: https://core.trac.wordpress.org/ticket/58193
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.