Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

57304: Mark credentials with SensitiveParameter attribute #4147

Closed
wants to merge 5 commits into from

Conversation

petitphp
Copy link

@petitphp petitphp commented Feb 28, 2023

Mark credentials with the new SensitiveParameter attribute available in PHP 8.2 to hide them in stack traces or log.

Trac ticket: https://core.trac.wordpress.org/ticket/57304


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props petitphp, johnbillion.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@johnbillion johnbillion requested a review from jrfnl September 24, 2024 16:18
Copy link
Member

@johnbillion johnbillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me. I added the attribute to a few more parameters.

The stack trace correctly marks the corresponding parameter as Object(SensitiveParameterValue) in stack traces:

#0 src/wp-includes/class-wpdb.php(773): wpdb->db_connect()
#1 src/wp-includes/load.php(695): wpdb->__construct('root', Object(SensitiveParameterValue), 'wordpress_devel...', 'mysql')
#2 src/wp-settings.php(132): require_wp_db()

@johnbillion
Copy link
Member

@jrfnl If you'd like to give this the nod then I'll get it in.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@johnbillion
Copy link
Member

Ah we still need to verify that WP Parser handles this change ok so the developer.wordpress.org site can still be generated correctly. I'll test it.

@johnbillion
Copy link
Member

Okay I finally got WP-Parser running locally on a PHP 7.4 container, at least enough to get it to parse the source and populate the parsed data. It looks to be working as expected and parsing each of the function parameters. The data displayed on the page comes from the @param tags anyway. This is good to go.

Copy link

github-actions bot commented Feb 3, 2025

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 59754
GitHub commit: 85d00ec

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants