Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns: Fix core 'Featured' pattern category registration #2640

Closed

Conversation

Mamaduka
Copy link
Member

Backports changes from WordPress/gutenberg#40650.

Patch fixes regression introduced in a807e86, and moves core "Featured" pattern category registraion from _load_remote_featured_patterns into _register_core_block_patterns_and_categories

Testing Instructions

  1. Activate the 2016 theme or any theme that doesn't register Featured pattern categories.
  2. Open a Post or Page.
  3. Open Block inserter -> Patterns Tab
  4. Confirm that the "Featured" patterns category is registered.

Trac ticket: https://core.trac.wordpress.org/ticket/55567

cc @gziolo, @hellofromtonya


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gziolo
Copy link
Member

gziolo commented Apr 29, 2022

Committed with https://core.trac.wordpress.org/changeset/53312.

@gziolo gziolo closed this Apr 29, 2022
@Mamaduka Mamaduka deleted the fix/patterns-featured-category branch September 13, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants