Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inital setup of visual regression tests. #209

Closed
wants to merge 14 commits into from
Closed

Inital setup of visual regression tests. #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9d45961
Inital setup of visual regression tests.
tellthemachines Apr 2, 2020
2101867
Add diff console dump.
tellthemachines Apr 2, 2020
9289f72
Ignore common dynamic elements and blur pixels
tellthemachines Apr 9, 2020
f411433
Check element exists before hiding it.
tellthemachines Apr 9, 2020
d006782
Hide site name and increase blur.
tellthemachines Apr 9, 2020
1dc113d
Up failure threshold.
tellthemachines Apr 9, 2020
fccb787
Try to fix tests on Travis
tellthemachines Apr 9, 2020
4ef4753
Update snapshot and lower failure threshold
tellthemachines Apr 9, 2020
93b2ba3
Revert whitespace changes
tellthemachines Jan 14, 2021
8bd91d1
Add custom setup and ignore snapshot files.
tellthemachines Jan 14, 2021
1c7ef85
Address review comments
tellthemachines Jan 28, 2021
24c43ad
Add some docs on how to run the tests.
tellthemachines Mar 24, 2021
78366fc
Replace timeout with puppeteer function.
tellthemachines Mar 25, 2021
a4a1293
Remove redundant puppeteer download.
tellthemachines Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,6 @@ wp-tests-config.php

# Files for local environment config
/docker-compose.override.yml

# Visual regression test diffs
tests/visual-regression/specs/__image_snapshots__
Copy link
Contributor

@talldan talldan Jan 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how, but I guess this also has to be added to the upstream SVN repo, like an svn:ignore equivalent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very good question 😅 hopefully someone knows the answer to.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the folder will need to be excluded upstream when committing by updating svn props.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and the changed svn props can also be committed afterwards, if easier. As far as I see svn:ignore __image_snapshots__ will have to be added to the parent dir, tests/visual-regression/specs.

Loading