Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site editor and block theme infrastructure #1825

Conversation

noisysocks
Copy link
Member

@noisysocks noisysocks commented Nov 8, 2021

#1796 and #1804 depend on each other for tests to pass, so this PR merges both of those PRs into a single big branch. Hopefully that means we can fix tests and commit.

Trac ticket:
https://core.trac.wordpress.org/ticket/54335
https://core.trac.wordpress.org/ticket/54337

To do:

  • Fix tests
  • Add verify:source-maps back
  • Use WP_Theme_JSON_Resolver::get_user_custom_post_type_id in site-editor.php
  • Remove wp_get_global_settings stub
  • Remove wp_is_fse_theme stub
  • Run tests/gutenberg/run.js

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

ockham and others added 30 commits November 8, 2021 14:17
Co-authored-by: Tonya Mork <[email protected]>
Co-authored-by: Tonya Mork <[email protected]>
Co-authored-by: Tonya Mork <[email protected]>
Co-authored-by: Tonya Mork <[email protected]>
Co-authored-by: Tonya Mork <[email protected]>
Co-authored-by: Tonya Mork <[email protected]>
Co-authored-by: Tonya Mork <[email protected]>
Co-authored-by: Tonya Mork <[email protected]>
@noisysocks noisysocks changed the base branch from trunk to master November 8, 2021 05:17
@desrosj desrosj changed the base branch from master to trunk November 8, 2021 13:42
@desrosj
Copy link
Contributor

desrosj commented Nov 8, 2021

I've changed the base of this PR to trunk. This is now the default branch going forward. See the original proposal that is finally being put in place.

@noisysocks noisysocks closed this Nov 8, 2021
@noisysocks noisysocks deleted the add/site-editor-and-block-theme-infrastructure branch November 8, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants