Add option to paginate_links
to apply format on all pages
#1540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/53868
paginate_links
doesn't use the providedformat
when the page is1
. This is great for the main query as it removes the extra query params making the URL shorter, but in the case of custom queries is problematic.If no additional data is appended via. add args / add fragment, the string remains empty at the time of output, which browsers then default it to the current page URL.
The code for this behavior is this:
$link = str_replace( '%_%', 1 == $n ? '' : $args['format'], $args['base'] );
My proposed solution is to add a new
format_all_pages
option inpaginate_links
that would enforce applying the format for all pages, including the first one. I could use some input for a better name for this option 😄 .Notes
In order to test this properly you have to enable pretty permalinks. If not the url will have the
page_id
param and therefore the final url will not be empty.Testing instructions
To reproduce:
Query Loop
block, set theItems per Page
to1
and make sure theinherit
isfalse
. After that insert aQuery Pagination
block insideQuery Loop
.navigate to the second page
of the query.To test the solution:
Query Pagination Numbers
:https://github.com/WordPress/wordpress-develop/blob/master/src/wp-includes/blocks/query-pagination-numbers.php#L46 and add the new option:format_all_pages = true
. (Noting that this will need a follow up in GB to update the block functionality.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.