-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename retrieve_widgets to recover_lost_widgets #1524
Rename retrieve_widgets to recover_lost_widgets #1524
Conversation
I've seen the comment with "lost" in it, but I feel the |
@draganescu it does a lot of things and it's hard to come up with a good name – I think |
Thanks for renaming @adamziel. LGTM now! |
This is kinda teetering on the line of refactoring for the sake of refactoring. If we do this rename, I think we should just soft deprecate the |
It has that feeling for sure. The thing is that the
Soft deprecate as in don't call _deprecated_function and only do |
Yeah, that'd be my thinking. |
@TimothyBJacobs done done in e5ce087 ! Would you confirm it's what you had in mind? |
That looks great to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, the new name is better. Why? It's more clear of the reason this function exists as well as what it will do. That makes it more readable and understandable. I agree this is a good change 👍
- All instances of
retrieve_widgets()
have been replaced ✅ retrieve_widgets()
has been soft deprecated ✅- Tests
@covers
are updated ✅ - PHPCS passes ✅
- Tests pass ✅
This PR is ready for commit
.
Merged with changeset https://core.trac.wordpress.org/changeset/51705. |
Trac ticket: https://core.trac.wordpress.org/ticket/53816
Trac ticket: https://core.trac.wordpress.org/ticket/53811
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.