Block Editor: Add missing border setting #1513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable border setting for Button block. See: #53697.
| @@ -1,6 +1,9 @@ | |||
| { | |||
| "version": 1, | |||
| "settings": { | |||
| "border": { | |||
| "customRadius": false | |||
There was a problem hiding this comment.
Could we enable the setting by default to all blocks?
There was a problem hiding this comment.
I copied this setting from the plugin. So I'm not sure if we want to enable it for all blocks by default.
|
Any chance this can make its way into the 5.8.1 milestone, given that it’s a regression and takes away an option that was previously there? |
jorgefilipecosta
approved these changes
Aug 3, 2021
|
Merged into Core in https://core.trac.wordpress.org/changeset/51538. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/53697
Adds missing border setting and enables it for Button block.
I've only included border-radius settings. I wasn't sure about the others.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.