Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images for block editor's Welcome Guide #1269

Closed

Conversation

noisysocks
Copy link
Member

@noisysocks noisysocks commented May 20, 2021

Trac ticket: TBD

Adds the image assets necessary for WordPress/gutenberg#32026.

To test:

  1. Clone the wordpress-develop repo, check out Add images for block editor's Welcome Guide #1269, build using npm i; grunt build.
  2. Clone the gutenberg repo, check out Update Welcome Guides to use external image URLs gutenberg#32026, build using npm i; npm run build.
  3. Configure your environment to run both local copies. For example, if using wp-env, modify gutenberg/.wp-env.json to set "core": "/path/to/wordpress-develop/build", then run wp-env start.
  4. Go to Posts → Add New, open the Options menu, and click Welcome Guide. The guide's images should appear normally.
  5. Go to Appearance → Widgets, open the Options menu, and click Welcome Guide. The guide's images should appear normally.
  6. Go to Appearance → Customize → Widgets, open the Options menu, and click Welcome Guide. The guide's image should appear normally.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@noisysocks noisysocks marked this pull request as ready for review May 20, 2021 05:24
@noisysocks noisysocks closed this May 28, 2021
@noisysocks noisysocks deleted the add/welcome-guide-images branch May 28, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant