Skip to content

Commit

Permalink
Tests: Use better domain for HTTP API invalid hostname test.
Browse files Browse the repository at this point in the history
The previous domain that was used to test for a host whose IPv4 address cannot be resolved, `exampleeeee.com`, got registered and has an A-record now, so it's not invalid anymore.

`.invalid` is intended for use in online construction of domain names that are sure to be invalid and which it is obvious at a glance are invalid.

Reference: [https://datatracker.ietf.org/doc/html/rfc2606#section-2 Reserved Top Level DNS Names: TLDs for Testing, & Documentation Examples].

Follow-up to [52084], [58384], [58388].

Props sippis, johnbillion, MattyRob, swissspidy.
Fixes #62303.

Reviewed by 
Merges [59293] to the 6.4 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/6.4@59300 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
peterwilsoncc committed Oct 27, 2024
1 parent 62cb57a commit 43e9f1f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/phpunit/tests/http/http.php
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ public function data_wp_http_validate_url_should_not_validate() {
'url' => 'http://[exam]ple.com/caniload.php',
),
'a host whose IPv4 address cannot be resolved' => array(
'url' => 'http://exampleeeee.com/caniload.php',
'url' => 'http://example.invalid/caniload.php',
),
'an external request when not allowed' => array(
'url' => 'http://192.168.0.1/caniload.php',
Expand Down

0 comments on commit 43e9f1f

Please sign in to comment.