Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal Error Fix: Remove unnecessary comma that causes a site-wide fatal server error on PHP 7.2 #547

Merged
merged 4 commits into from
Mar 27, 2023

Conversation

KZeni
Copy link
Contributor

@KZeni KZeni commented Mar 27, 2023

I'm going to be a bit brief on these details as this is a hot issue needing a hot fix.

I've started a support forum topic on this at https://wordpress.org/support/topic/fatal-error-php-7-2-syntax-error-breaking-whole-site-3/ for further discussion/reference/etc. as well.

@KZeni
Copy link
Contributor Author

KZeni commented Mar 27, 2023

Created an issue at #548 just in case that's helpful for reference & as a more complete reporting of things (WP.org support forum + GH issue + GH PR.)

@KZeni
Copy link
Contributor Author

KZeni commented Mar 27, 2023

Just in case it helps speed up the release of the hotfix, I made an additional edit to update the 3 times the version is mentioned in readme.txt & two-factor.php from 0.8.0 to 0.8.0.1 since this really is a hotfix for this one previous release.

Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this and helping out with a quick PR!

I don't have a 7.2 box readily available for testing, but I'm assuming it works on your end. The diff looks good and tests fine on 8.0

I removed the version bump, since we do that during the release process.

#461 should add automated version testing

@iandunn iandunn merged commit 7d0ffeb into WordPress:master Mar 27, 2023
@iandunn iandunn mentioned this pull request Mar 27, 2023
@iandunn
Copy link
Member

iandunn commented Mar 27, 2023

@KZeni 0.8.1. is now available on wordpress.org. Please let me know if you run into any issues installing it or after.

@jeffpaul jeffpaul added this to the 0.8.1 milestone Apr 4, 2023
@jeffpaul jeffpaul linked an issue Apr 4, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal Error: PHP 7.2 Syntax Error (breaking whole site)
3 participants