Update deploy.yml

[jeffpaul]

What?

Updates the current deploy.yml file by swapping in https://github.com/10up/action-wordpress-plugin-deploy for the steps to deploy to SVN.

Why?

Deploys to SVN are disabled as they're currently failing, see:

two-factor/.github/workflows/deploy.yml

Line 44 in c0eae28

# Disable deployments while they are failing for unknown reason.

.

How?

Replaces the previous Authenticate with WordPress.org SVN and Deploy to WordPress.org SVN steps with WordPress Plugin Deploy and Upload release asset steps utilizing the https://github.com/10up/action-wordpress-plugin-deploy GitHub Action.

Note that this also ONLY deploys on published releases and no longer on ANY merge to master which means that only newly released versions will be deployed to SVN and any individual merges to master on GitHub will no longer be deployed to trunk on SVN.

Testing Instructions

This is a tough one, pretty much need to YOLO into a published release and 🤞🏼 that the Action processes correctly (e.g., that SVN_USERNAME, SVN_PASSWORD, and GITHUB_TOKEN are accurate).

Screenshots or screencast

n/a

Changelog Entry

Changed - Deploy workflow uses 10up/action-wordpress-plugin-deploy instead of a manual connection to SVN.

[jeffpaul]

Open to whether we try this with 0.8.0 or figure out post-release.

[iandunn]

I don't have a strong opinion, but this sounds good to me 👍🏻

[dd32]

I have no strong opinion here. I can confirm all the secret constants are correct.

However, I'm 99% certain this won't work as-is, see suggestions:

• npm run build needs to happen after npm install to actually build the plugin (npm run deploy did this previously)
• BUILD_DIR: dist needs to be added to the env

I can't test this, as npm run build doesn't work on my environments,

[kasparsd]

This looks good!

The build process is being tested as part of this step in the other CI file:

two-factor/.github/workflows/test.yml

Lines 47 to 48 in a9b5492

	- name: Build
	run: npm run build

and it is running correctly:

https://github.com/WordPress/two-factor/actions/runs/4471733733/jobs/7856996785?pr=543#step:12:17

As long as the deploy action picks up the files at dist/* (after implementing the suggestion from @dd32), it should be all good!

[kasparsd]

I can't test this, as npm run build doesn't work on my environments

@dd32 Do you know why that is? Should we create an issue to fix that? Technically all of the build logic should be handled by Node with no external system dependencies. Would moving everything to wp-scripts solve the issue?

[dd32]

I can't test this, as npm run build doesn't work on my environments

dd32 Do you know why that is? Should we create an issue to fix

And suddenly now when I went to copy the error, everything works. Magic. (I haven't tested this PR, but visual review looks like it'll work to me)

Sorry for the false alarm.

[jeffpaul]

@kasparsd if you're 👍🏼 on this, feel free to merge and then proceed with the steps on #533 to complete the 0.8.0 release (happy to handle those myself if you're good on this PR to ensure we're not blocked on the release deploy to SVN).

Noting here that ideally we'd sneak #540 into 0.8.0 but I do not view that as a blocker.