Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include whitespace between the leading text and the actual input. #519

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Feb 14, 2023

The two factor authentication screens have no whitespace between the text and the input, this tends to lead to a cramped interface.

Provider Before After
TOTP Screenshot 2023-02-14 at 1 53 46 pm Screenshot 2023-02-14 at 1 53 29 pm
Email Screenshot 2023-02-14 at 1 58 02 pm Screenshot 2023-02-14 at 1 57 22 pm
Backup Codes Screenshot 2023-02-14 at 1 58 25 pm No change, whitespace was already present.

See #515

Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@dd32 dd32 merged commit 2991f4c into WordPress:master Feb 15, 2023
@jeffpaul jeffpaul added this to the 0.8.0 milestone Feb 15, 2023
@jeffpaul
Copy link
Member

Really nice UX improvements, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emailed Codes TOTP Time-based One-time Passwords
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants